Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow core and plugins to specify which Python version to test against #457

Closed
daviddavis opened this issue Jul 21, 2021 · 13 comments · Fixed by #459
Closed

Allow core and plugins to specify which Python version to test against #457

daviddavis opened this issue Jul 21, 2021 · 13 comments · Fixed by #459

Comments

@daviddavis
Copy link
Contributor

The CI uses the pulp_ci_centos image which already has a version of Python installed. Currently, that's Python 3.8. However, we're still releasing older versions of pulpcore and plugins that support Python 3.6 and we need a way to have our CI test against Python 3.6.

@mdellweg mdellweg changed the title Allow core and plugins to specify which Python plugin to test against Allow core and plugins to specify which Python version to test against Jul 21, 2021
@fao89
Copy link
Member

fao89 commented Jul 21, 2021

@daviddavis
Copy link
Contributor Author

Interesting, how was the python36 tag generated?

@fao89
Copy link
Member

fao89 commented Jul 22, 2021

I reverted python38 commit and manually built and push it

@bmbouter
Copy link
Member

@fao89 Do you understand what could be done to have the plugin template get a new variable that could specify which image to use? I'm about to release pulpcore==3.14 and also pulpcore==3.7 and if I reapply the plugin template (which I need to for 3.7 at least) it'll CI against Python 3.8 which I'd like it to have it CI against Python 3.6 instead. Is this something you could possibly help with? @dkliban or do you have any ideas?

@dkliban
Copy link
Member

dkliban commented Jul 22, 2021

@bmbouter don't update to the latest plugin_template config on the 3.14 branch. is there something specific you need from latest?

@fao89
Copy link
Member

fao89 commented Jul 22, 2021

Currently it switches between latest and https
https://github.com/pulp/plugin_template/blob/master/templates/github/.github/workflows/scripts/install.sh.j2#L117
we can make this logic smarter

@bmbouter
Copy link
Member

Well for the 3.7 branch I need the auto-release stuff. And 3.14 is going to be around a long time so over time we'll have to reapply.

@daviddavis
Copy link
Contributor Author

We'd need to do more than just switch the ci container image over to use the python36 tag. There are some paths and stuff in the CI files that will need to be updated. But that said, it should be fairly easy.

@bmbouter
Copy link
Member

Sounds good. I can do the 3.14.3 release, but I am blocked on the 3.7 release (the one we really need AIUI) until this is done.

@daviddavis
Copy link
Contributor Author

Can you have the 3.7 release branch run against python 3.8 for now?

Also, how urgently do you need this? If it's urgent, I think I could make some time to work on it tomorrow.

Lastly, just to add: this'll be a bit of a hack and longer term I think we want a way to generate different base CI images with different python versions.

@bmbouter
Copy link
Member

bmbouter commented Jul 22, 2021

Can you have the 3.7 release branch run against python 3.8 for now?

I'm ok with this, but I was ok from the beginning. What I don't want to do is not use our fully automated release machinery. Shall I just run with 3.8 for now?

Also, how urgently do you need this? If it's urgent, I think I could make some time to work on it tomorrow.

After these I don't know of more 3.7 branch releases so maybe not for a few weeks? Really this request originated from @goosemania who was requesting on behalf of katello.

Lastly, just to add: this'll be a bit of a hack and longer term I think we want a way to generate different base CI images with different python versions.

Agreed.

@daviddavis
Copy link
Contributor Author

I'm ok with this, but I was ok from the beginning. What I don't want to do is not use our fully automated release machinery. Shall I just run with 3.8 for now?

It's worth a try.

@goosemania
Copy link
Member

Also, how urgently do you need this? If it's urgent, I think I could make some time to work on it tomorrow.

After these I don't know of more 3.7 branch releases so maybe not for a few weeks? Really this request originated from @goosemania who was requesting on behalf of katello.

The tasking bug blocks some QE testing for pulp-2to3-migration. If we have a patch ready for 3.7, I can share it with QE and they will likely be able to patch their automation.
Definitely no need to push to get the release out this week, next week would be nice butI can figure out a specific deadline based on the build team schedule if you prefer to have a specific date.

daviddavis pushed a commit to daviddavis/plugin_template that referenced this issue Jul 23, 2021
daviddavis pushed a commit to daviddavis/plugin_template that referenced this issue Jul 23, 2021
daviddavis pushed a commit to daviddavis/plugin_template that referenced this issue Jul 23, 2021
daviddavis pushed a commit to daviddavis/plugin_template that referenced this issue Jul 26, 2021
daviddavis pushed a commit to daviddavis/plugin_template that referenced this issue Jul 26, 2021
daviddavis pushed a commit to daviddavis/plugin_template that referenced this issue Jul 26, 2021
daviddavis pushed a commit that referenced this issue Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants