Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for creating a new release branch #417

Closed
dkliban opened this issue Jun 22, 2021 · 3 comments · Fixed by #418
Closed

Add workflow for creating a new release branch #417

dkliban opened this issue Jun 22, 2021 · 3 comments · Fixed by #418

Comments

@dkliban
Copy link
Member

dkliban commented Jun 22, 2021

The new workflow should triggered manually from master branch. It needs to take a name parameter. The workflow needs to check that the branch name matches up with the current version on master branch. If the name of the branch and the X.Y portion of the version string match, the workflow should create a new branch that is exactly like master and then bump the version on master and open a PR with that version bump.

@mdellweg
Copy link
Member

Should the release branch not be a side effect of the release workflow when run for a minor release?
Do we need an extra workflow?

@daviddavis
Copy link
Contributor

daviddavis commented Jun 22, 2021

Having a separate workflow would allow us to branch independently from releasing. Perhaps if we want to merge commits to master that we don't want to release in the next y-release (but aren't ready to release yet).

Also, as the current release workflow stands, you release a branch (and not a commit) so if people are merging to master, there's no guarantee which commit gets branched/released. We could add a field though to specify a specific commit.

dkliban added a commit to dkliban/plugin_template that referenced this issue Jun 22, 2021
The workflow needs to be run on master branch. It creates a new branch and
also opens a PR against master branch with a minor version bump.

fixes: pulp#417
dkliban added a commit to dkliban/plugin_template that referenced this issue Jun 22, 2021
The workflow needs to be run on master branch. It creates a new branch and
also opens a PR against master branch with a minor version bump.

fixes: pulp#417
@mdellweg
Copy link
Member

So you are saying we might branch a week before releasing without holding the development on master.
That sounds like an implementation of a "feature freeze". That actually sounds really good.

dkliban added a commit that referenced this issue Jun 29, 2021
The workflow needs to be run on master branch. It creates a new branch and
also opens a PR against master branch with a minor version bump.

fixes: #417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants