Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fall_through_register description #244

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix fall_through_register description #244

merged 1 commit into from
Dec 4, 2024

Conversation

mp-17
Copy link
Contributor

@mp-17 mp-17 commented Oct 17, 2024 •
edited
Loading

The description of the fall_through_register says that it does not cut any combinatorial paths.

This looks wrong, as the ready path seems actually cut (ready_o depends on fifo_full only, which does not depend on any other interface signal).

niwis
niwis requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@niwis niwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change this to "does not cut the combinatorial path on the valid and data signals" or similar? To me, this seems more relevant

@niwis niwis requested a review from thommythomaso October 31, 2024 05:41
@mp-17
Copy link
Contributor Author

mp-17 commented Nov 1, 2024

Done, I specified both!

@niwis niwis merged commit e66a131 into master Dec 4, 2024
5 checks passed
@niwis niwis deleted the fix/comment branch December 4, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niwis niwis niwis approved these changes

@thommythomaso thommythomaso Awaiting requested review from thommythomaso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mp-17 @niwis