Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credit_counter #225

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Add credit_counter #225

merged 2 commits into from
Jul 18, 2024

Conversation

micprog
Copy link
Member

@micprog micprog commented Jul 17, 2024

No description provided.

Co-authored-by: Paul Scheffler <[email protected]>
@micprog micprog requested review from niwis and paulsc96 July 17, 2024 15:32
Copy link
Collaborator

@niwis niwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @micprog, thanks for upstreaming this! I just have one minor suggestion


logic credit_load;
assign credit_load = 1'b1;
`FFLARNC(credit_q, credit_d, credit_load, credit_init_i, InitNumCredits, clk_i, rst_ni)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use FFARNC instead of tying the load enable?

@niwis niwis merged commit 77a086f into master Jul 18, 2024
5 checks passed
@niwis niwis deleted the michaero/credit_counter branch July 18, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants