Renamed translate_off to ` ifndef SYNTHESIS ``
#210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niwis
requested changes
Mar 6, 2024
There was a problem hiding this comment.
@sifferman thanks a lot for your contribution, and sorry for my late response. To make this complete, could you also replace the pragmas in stream_fifo_optimal_wrap.sv?
I'm open to updating this in the deprecated modules but don't think it's strictly necessary.
Closed
|
@niwis Thanks for the response, and good catch! I corrected stream_fifo_optimal_wrap.sv. I also added the changes for the deprecated modules. I can squash if needed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
According to the IEEE 1364.1-2005 spec 6.3.2, the use of
translate_off/translate_onis discouraged as opposed to`ifndef SYNTHESIS. Plus, some newer SystemVerilog frontends such as sv2v, Verible, and PySlint do not have any extra AST support fortranslate_off, so they may get confused by unsupported unsynthesizable constructs.Therefore, I changed 38 occurrences of
translate_offto`ifndef SYNTHESIS. However, I kept 4 deprecated modules withtranslate_offbecause I wasn't sure whether they should match the non-deprecated modules' style:"src/deprecated/generic_fifo.sv""src/deprecated/generic_fifo_adv.sv""src/deprecated/find_first_one.sv""src/deprecated/fifo_v2.sv"Also, I would be happy to hear another perspective if you feel that
translate_offis in fact the better option.Thanks!