Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fetches to bypass prefetches to L1 #7

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

micprog
Copy link
Member

@micprog micprog commented Feb 20, 2024

No description provided.

@micprog micprog marked this pull request as ready for review February 20, 2024 17:13
@micprog micprog force-pushed the michaero/fetch_priority branch from a1339bd to 164d326 Compare February 27, 2024 15:02
Copy link

@paulsc96 paulsc96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would have instantiated another stream_arbiter with .ARBITER ("prio") for the final selection between prefetch and fetch though; would make it a bit more readable.

@micprog
Copy link
Member Author

micprog commented Feb 28, 2024

LGTM. I would have instantiated another stream_arbiter with .ARBITER ("prio") for the final selection between prefetch and fetch though; would make it a bit more readable.

I don't think this will work, as LockIn is required (to ensure stable signalling when a low priority fetch is stalled and a high priority fetch arrives) but not supported in the rr_arb_tree when configured to use ExtPrio. I agree on the sentiment, though. Should the rr_arb_tree be modified to support this? In another thought, should this stream_arbiter with priority levels be collected into a common_cell? @niwis

@micprog micprog force-pushed the michaero/fetch_priority branch from 164d326 to a793ea4 Compare March 5, 2024 17:06
@micprog micprog merged commit a5f3758 into main Mar 5, 2024
7 checks passed
@micprog micprog deleted the michaero/fetch_priority branch March 5, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants