Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create OBI-compatible icache wrapper #5

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

micprog
Copy link
Member

@micprog micprog commented Feb 20, 2024

Adds an OBI-compatible wrapper for the icache, converting the OBI request into the snitch_icache fetch protocol. While multiple adapters are added, only one was properly tested.

This allows using the icache in systems such as the pulp_cluster and safety_island, with cores such as ibex or cv32e40p.

@micprog micprog force-pushed the michaero/pulp_wrapper branch from 7f6210f to e4b241a Compare February 27, 2024 15:04
@micprog micprog force-pushed the michaero/pulp_wrapper branch from e4b241a to 8f0efe7 Compare March 21, 2024 14:05
@micprog micprog force-pushed the michaero/pulp_wrapper branch 2 times, most recently from a2723f8 to 90baeb8 Compare June 20, 2024 15:38
@micprog micprog force-pushed the michaero/pulp_wrapper branch from 90baeb8 to e7e9de3 Compare August 20, 2024 15:24
@micprog micprog marked this pull request as ready for review August 20, 2024 15:45
@micprog micprog requested review from Scheremo and removed request for SamuelRiedel and paulsc96 August 20, 2024 15:45
@micprog micprog changed the title Create wrapper for PULP cluster Create OBI-compatible icache wrapper Aug 20, 2024
Copy link
Contributor

@colluca colluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the functionality has been separately tested, but the refactoring looks good to me. Just adding a few minor comments.

Bender.yml Show resolved Hide resolved
src/obi_icache_wrap.sv Show resolved Hide resolved
Copy link

@alex96295 alex96295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, for final LGTM needs basic in-system test with at least one adapter variant (e.g. in safety island)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants