Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump PULP cluster to fix macro implementation #194

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Bump PULP cluster to fix macro implementation #194

merged 1 commit into from
Oct 12, 2023

Conversation

yvantor
Copy link
Contributor

@yvantor yvantor commented Oct 12, 2023 •
edited by alex96295
Loading

The PR provides:

  • Replace latches in rapid recovery RF with FFs
  • Bumps of the PULP cluster commits to kill the critical path in the DMR checkers (fixes time violations in synthesis, should fix it also in P&R, which is running at the moment)
  • Bumps of the PULP cluster commits to try and fix the post-synthesis/layout simulations of the PULP cluster by using a structures-based AXI crossbar instead of the one using interfaces (this could be the reason why only AXI indeces are swapped in synthesis, but the address map is not changed accordingly)
  • A lot of repetitive commits that must be properly squashed :)

@yvantor yvantor requested a review from alex96295 as a code owner October 12, 2023 16:42
@yvantor yvantor self-assigned this Oct 12, 2023
@yvantor yvantor added enhancement New feature or request bug-fix Something wasn't working and it is being fixed labels Oct 12, 2023
@alex96295
Copy link
Collaborator

@mp-17 @anga93

@mp-17
Copy link
Contributor

mp-17 commented Oct 12, 2023

Are we also replacing latches with FFs? If yes, we can merge. Thanks a lot guys

@yvantor
Copy link
Contributor Author

yvantor commented Oct 12, 2023

Are we also replacing latches with FFs? If yes, we can merge. Thanks a lot guys

Yep, we are serious people here

alex96295
alex96295 reviewed Oct 12, 2023
View reviewed changes
Bender.yml Outdated Show resolved Hide resolved
@yvantor yvantor force-pushed the yt/pulp-bump branch 2 times, most recently from 88a102d to 201de22 Compare October 12, 2023 17:33
@alex96295
Bender: Bump integer cluster
9cdf790 
* Replace latches with FFs in rapid recovery RF
* Fix critical path through DMR checker
* Bump the PULP cluster commits to try and fix the post-synthesis/layout
simulations of the PULP cluster by using a structures-based AXI crossbar
instead of the one using interfaces (this could be the reason why only
AXI indeces are swapped in synthesis, but the address map is not changed
accordingly)
@alex96295 alex96295 changed the title Bump PULP cluster to fix macro implementation. Bump PULP cluster to fix macro implementation Oct 12, 2023
@alex96295 alex96295 merged commit 4c1870a into main Oct 12, 2023
4 of 6 checks passed
@alex96295 alex96295 deleted the yt/pulp-bump branch October 12, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex96295 alex96295 alex96295 left review comments

Assignees

@yvantor yvantor

Labels
bug-fix Something wasn't working and it is being fixed enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yvantor @alex96295 @mp-17