Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hw: Fix instantiation of reg cdc for external reg interface #188

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

alex96295
Copy link
Collaborator

@alex96295 alex96295 commented Oct 8, 2023

  • The for loop was iterating on the number of synchrnous interfaces instead of asyncrhonous, with the former set to 1. Hence, only one reg cdc for port 0 was generated!

* The for loop was iterating on the number of synchrnous interfaces
isntead of asyncrhonous, with the former set to 1. hence, Only one reg
cdc for port 0 was generated!
@alex96295 alex96295 added bug Something isn't working bug-fix Something wasn't working and it is being fixed labels Oct 8, 2023
@alex96295 alex96295 requested a review from bluewww October 8, 2023 21:02
Copy link
Contributor

@yvantor yvantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recursive bug (I remember we fixed this months ago 😄 )

Copy link
Contributor

@bluewww bluewww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alex96295 alex96295 merged commit 45a8f2e into main Oct 9, 2023
7 checks passed
@alex96295 alex96295 deleted the aottaviano/fix-ext-reg branch October 9, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bug-fix Something wasn't working and it is being fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants