-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SW] Add kernels: gemv, spmv, conjugate gradient #175
Conversation
Thanks a lot @husterZC, I will check it asap! |
Hi Matteo, one thing to notice: In the conjugate_gradient/shared_kernels. these are all soft link files, but I don't know why we I push them, they loss the link. Could you please fix them yourself, either make a hard copy or make a link file. And for some workloads using other kernels, do you suggest to make a link or a hard copy? |
I would prefer symlinks to avoid duplicated code. I created a PR to your |
[SW] Fix conjugate_gradient/shared_kernel simlinks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the contribution!
Can you please pass everything through clang-format
and adjust the vertical alignment in apps/common/default_args.mk
?
Then, if the CI checks pass, LGTM!
@husterZC Ping me if you need support! :-) |
To be honest, I'm busy on other stuff. I plan to fix this last in this week |
Hey Matteo, I've added the dependence of
|
Hi Matteo, I wonder how to add the python package "sklearn" in the CI environment, otherwise it will always sticking here ;) |
I will check everything and merge here -> #267 |
Description of PR that completes issue here...
Added