Skip to content
This repository has been archived by the owner on May 14, 2022. It is now read-only.

Implement Bulk Label Interface #182

Merged
merged 1 commit into from
Nov 25, 2015
Merged

Implement Bulk Label Interface #182

merged 1 commit into from
Nov 25, 2015

Conversation

tpendragon
Copy link
Contributor

This is an interface for bulk labeling/previewing/persisting those
labels. Closes #7, closes #170

@tpendragon
Copy link
Contributor Author

screen shot 2015-11-24 at 12 49 40 pm

This is what it looks like.

@escowles
Copy link
Member

This looks very nice. I spun it up locally and played with it and everything worked as expected, except:

  • the updates didn't trigger reindexing in Solr
  • clicking Save didn't take me back to the ScannedResource (or we add a button to go back to the ScannedResource)

@tpendragon
Copy link
Contributor Author

the updates didn't trigger reindexing in Solr

Are you sure? It's using the file set update action, this would be odd. Steps to reproduce?

@escowles
Copy link
Member

You're right -- it is updated Solr. It's just that the ScannedResource view of the FileSets is using ebucore:filename instead of dc:title, so the display wasn't updated. I've created #183 for using dc:title (if available).

This is an interface for bulk labeling/previewing/persisting those
labels. Closes #7
@tpendragon
Copy link
Contributor Author

@escowles Added a link back to parent.

escowles added a commit that referenced this pull request Nov 25, 2015
Implement Bulk Label Interface
@escowles escowles merged commit 3aaff2e into master Nov 25, 2015
@escowles escowles deleted the bulk_labeller branch November 25, 2015 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jasmine for Javascript? Easy interface to bulk add labels to a set of pages
2 participants