-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding build script #44
base: master
Are you sure you want to change the base?
Conversation
@webmozart do have you an idea why the tests failing on my own travis channel? |
we also have to declare where you store the build foreach version. we should chat maybe in the sulu slack-channel about the details. i think i have build the basics here and only have to adapt it when the details are defined. |
cache: | ||
directories: | ||
- $HOME/.composer/cache/files | ||
|
||
- $HOME/.composer/cache/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason why you removed these spaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no not really but the travis shell script removes it (:
@@ -25,13 +15,25 @@ wget -O box.phar ${BOX_URL} | |||
chmod 755 box.phar | |||
./box.phar build -vv | |||
|
|||
# TODO if build with gh-pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's happening with these TODOs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will remove it when its clear how we deploy the files (:
This PR will add an automatic build with travis.
This travis-builder will be used to test the deployment: https://travis-ci.org/wachterjohannes/cli