Address review feedback

pugnascotia · Jan 26, 2021 · 7fd090d · 7fd090d
1 parent e9a734a
commit 7fd090d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/server/src/main/java/org/elasticsearch/common/logging/ClusterIdConverter.java b/server/src/main/java/org/elasticsearch/common/logging/ClusterIdConverter.java
@@ -27,6 +27,8 @@
 
 /**
  * Pattern converter to format the cluster_id variable into JSON fields <code>cluster.id</code>.
+ * <p>
+ * This is used in `EcsJsonLayout`, which does not use {@link NodeAndClusterIdConverter}.
  */
 @Plugin(category = PatternConverter.CATEGORY, name = "ClusterIdConverter")
 @ConverterKeys({"cluster_id"})

diff --git a/server/src/main/java/org/elasticsearch/common/logging/NodeIdConverter.java b/server/src/main/java/org/elasticsearch/common/logging/NodeIdConverter.java
@@ -27,6 +27,8 @@
 
 /**
  * Pattern converter to format the node_id variable into JSON fields <code>node.id</code> .
+ * <p>
+ * This is used in `EcsJsonLayout`, which does not use {@link NodeAndClusterIdConverter}.
  */
 @Plugin(category = PatternConverter.CATEGORY, name = "NodeIdConverter")
 @ConverterKeys({"node_id"})