Trailing semicolon #2962
Merged
Trailing semicolon #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first draft that tries to maintain the same code behavior without worrying too much about the code quality
All style attributes that received a String won't generate a trailing semicolon
Check if String is not empty by checking if it its true ('' is false)
Get last character of the string using slice(-1)
Add semicolon if the last string character is not a semicolon
This was referenced Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #2961
By only adding a semicolon when merging two style attributes, single style strings do not receive anymore a semicolon.
I had to change the tests to reflect this new behavior