Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing public header in frameworks #424

Closed
wants to merge 1 commit into from

Conversation

dymv
Copy link

@dymv dymv commented Dec 22, 2020

Since update from 4.14.2 to 4.15.8 we noticed the following issue when compiling our project with PubNub framework built via Carthage:

<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "Headers/PubNub.h"
        ^
.../Carthage/Build/iOS/PubNub.framework/Headers/PubNub.h:63:9: note: in file included from .../Carthage/Build/iOS/PubNub.framework/Headers/PubNub.h:63:
#import "PubNub+Publish.h"
        ^
.../Carthage/Build/iOS/PubNub.framework/Headers/PubNub+Publish.h:3:9: note: in file included from .../Carthage/Build/iOS/PubNub.framework/Headers/PubNub+Publish.h:3:
#import "PNPublishFileMessageRequest.h"
        ^
.../Carthage/Build/iOS/PubNub.framework/Headers/PNPublishFileMessageRequest.h:1:9: error: 'PNBasePublishRequest.h' file not found
#import "PNBasePublishRequest.h"
        ^
.../PubNubStreamHandler.swift:4:8: error: could not build Objective-C module 'PubNub'
import PubNub
       ^

To fix this, the PR moves PNBasePublishRequest.h to the Public Group. Note: the change was made for each platform iOS, tvOS, watchOS, OSX (according to framework names), but only iOS was tested locally.

Move PNBasePublishRequest.h to Public Group
@parfeon parfeon self-assigned this Dec 22, 2020
@parfeon parfeon added status: accepted This issue is accepted as valid, but it's not being worked on yet. type: bug This issue reports a bug. labels Dec 22, 2020
@parfeon
Copy link
Contributor

parfeon commented Dec 22, 2020

@dymv thanks for reporting this issue.

It is surprising, that test builds of CocoaPods (1.9.3) and Carthage (0.36.0) on Travis didn't detected this misconfiguration.
We will make changes and notify about release.

@client-engineering-bot
Copy link
Contributor

@dymv your suggested changes are addressed in v4.15.9

@client-engineering-bot client-engineering-bot added status: done This issue is considered resolved. and removed status: accepted This issue is accepted as valid, but it's not being worked on yet. labels Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: done This issue is considered resolved. type: bug This issue reports a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants