Subscriber idle request reconnect and documentation fix #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When maximum subscribe request idle timeout reached, request fail with timeout error. PubNub SDK report unexpected disconnection and retry request. Because of issue (fixed) 'reconnect' event will be sent only at double time of configured subscribe request idle time (CE-3744) fix(configuration): fix heartbeat value on configuration copy Event when value not has been set, it was reset to minimum value (20) on configuration object copy. This has been fixed by direct assign to ivar. fix(documentation): fix outdated configuration object inline help documentation Fix default origin and minimum heartbeat value information in PNConfiguration header (CE-3743).
parfeon
added a commit
that referenced
this pull request
Jun 29, 2019
* fix: fix listeners list inherit race of conditions (#395) Fix issue because of which listener from which listenres has been inherited able to clean it before new listener will get that list (because new one make call on async private queue). * Removing version under the supported platform (#397) * fix(subscriber): fix subscribe request timeout missing 'reconnect' event (#398) When maximum subscribe request idle timeout reached, request fail with timeout error. PubNub SDK report unexpected disconnection and retry request. Because of issue (fixed) 'reconnect' event will be sent only at double time of configured subscribe request idle time (CE-3744) fix(configuration): fix heartbeat value on configuration copy Event when value not has been set, it was reset to minimum value (20) on configuration object copy. This has been fixed by direct assign to ivar. fix(documentation): fix outdated configuration object inline help documentation Fix default origin and minimum heartbeat value information in PNConfiguration header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 subscriber: fix subscribe request timeout missing 'reconnect' event
When maximum subscribe request idle timeout reached, request fail with
timeout error. PubNub SDK report unexpected disconnection and retry
request. Because of issue (fixed) 'reconnect' event will be sent only at double
time of configured subscribe request idle time.
🛠 configuration: fix heartbeat value on configuration copy
Event when value not has been set, it was reset to minimum value (20) on
configuration object copy. This has been fixed by direct assign to ivar.
🛠 documentation: fix outdated configuration object inline help documentation
Fix default origin and minimum heartbeat value information in PNConfiguration
header (CE-3743).