This repository has been archived by the owner on Apr 8, 2020. It is now read-only.
meta field access otb on pn msg in chat engine #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianjennings
suggested changes
Jan 17, 2018
| @@ -57,9 +57,13 @@ class Event { | |||
|
|
|||
| m.event = this.event; | |||
|
|
|||
| let meta = m.data.meta; | |||
| delete m.data.meta; | |||
There was a problem hiding this comment.
We should not modify payload.data or use it for configuration as this is "userland" and they will expect this object to be identical. ChatEngine should not care what payload.data is ever.
For example, a negative case would be where the user suppliespayload.data.meta for their own application, and the data will be removed and reassigned without their knowledge.
My first instinct is to supply this information within chat.emit and pass the information into event.publish.
https://github.com/pubnub/chat-engine/blob/meta/src/components/chat.js#L285
anonrig
reviewed
Jan 22, 2018
| this.chatEngine.pubnub.publish({ | ||
| message: m, | ||
| channel: this.channel | ||
| channel: this.channel, | ||
| meta: meta |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a developer to add properties to the meta object on a pubnub request. this can be used for auth tokens.