Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace broken links #2360

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

groundcat
Copy link
Contributor

This PR replaces all broken ccTLD links with IANA page links to resolve #2338

@wdhdev
Copy link
Contributor

wdhdev commented Dec 28, 2024

I feel like it would be better to find the updated pages instead of immediately switching to the IANA links, like I did in my previous PR.

@groundcat
Copy link
Contributor Author

That approach works for me as well. This PR follows dnsguru's suggested method, which involves replacing them with IANA database links. The reasoning is probably that all registry websites are sourced from and should be sourced from the IANA page anyway. However, I replaced only broken links in this PR, as I do not think we should replace all functional URLs with IANA pages or remove "see also" lines, as these comments could often be valuable documentation. They can help future maintainers understand the nuances of different TLDs or special cases. Whether these are included as comments in the list or elsewhere, the documentation and links to specific registry rules are nice to have.

@groundcat
Copy link
Contributor Author

groundcat commented Dec 28, 2024

So, it comes down to choosing between two directions:

  1. Expanding the documentation directly in the list's comments by having PSL volunteers check links from the IANA page and identify the list of suffixes. This approach enhances documentation but could increase the list size significantly due to more comments. Sometimes registries, like the cw registry, explicitly request specific links (e.g., https://www.uoc.cw/cw-registry) in their domain block.

  2. Following dnsguru's proposal to replace everything with IANA links, letting registries maintain their own entries. This simplifies the list but relies on registries to keep their information updated.

The first approach benefits documentation but might burden volunteers, while the second places responsibility on the registries, which is probably the ideal situation.

@wdhdev
Copy link
Contributor

wdhdev commented Dec 28, 2024

2. seems good for now. However I think if any volunteers have the free time and want to do so, I think they should be able to update the entries with registry links (maybe limit of 1-2 per section to prevent as much overhead as possible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potentially Broken Links in Comments
2 participants