Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tools/internal/parser): remove unneeded exceptions #2328

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

wdhdev
Copy link
Contributor

@wdhdev wdhdev commented Dec 11, 2024

The domains/sections removed from here have been removed from the PSL, except for is-a.dev, as that section is now correctly sorted.

I would leave this PR open until we merge a few of the other open removal PRs such as #2313, so we can update exceptions.go accordingly.

Let me know if I've missed any that no longer need to be here.

@wdhdev
Copy link
Contributor Author

wdhdev commented Dec 11, 2024

In 584dc94, the reason why the incorrectSort array is now empty, is because all entries are sorted correctly, so there is no need for them to be exempt.

I removed the Amazon exceptions as all their domains do have _psl TXT records in place. With any new PRs they still add the TXT records required (thank you Amazon ❤️), hence there is no reason to have an exception for them.

@wdhdev
Copy link
Contributor Author

wdhdev commented Dec 11, 2024

@simon-friedberger I think this can be merged. The other PRs open that may affect the exceptions by removing old domains, may take a little while before they are merged, so might as well remove these ones and we can worry about the other ones later.

@simon-friedberger simon-friedberger merged commit 77a1948 into publicsuffix:main Dec 11, 2024
2 checks passed
@wdhdev wdhdev deleted the patch-7 branch December 11, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants