Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update public_suffix_list.dat #2205

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

3aaber
Copy link
Contributor

@3aaber 3aaber commented Oct 8, 2024

Adding ArvanCloud Edge Compute Domain to public suffix list

Public Suffix List (PSL) Submission

Checklist of required steps

  • Description of Organization

  • Robust Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _psl TXT record in place in the respective zone(s).

Submitter affirms the following:

  • We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)

ArvanCloud does not submit suffixes to the Public Suffix List to work around rate-limits of any third-party products or tooling

  • This request was not submitted with the objective of working around other third-party limits.
  • The submitter acknowledges that it is their responsibility to maintain the domains within their section. This includes removing names which are no longer used, retaining the _psl DNS entry, and responding to e-mails to the supplied address. Failure to maintain entries may result in removal of individual entries or the entire section.
  • The Guidelines were carefully read and understood, and this request conforms to them.
  • The submission follows the guidelines on formatting and sorting.

For PRIVATE section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

  • Yes, I understand. I could break my organization's website cookies and cause other issues, and the rollback timing is acceptable. Proceed anyways.

Description of Organization

ArvanCloud is a cloud services provider, offering a wide range of cloud computing and content delivery network (CDN) services.
The company aims to improve website performance and security by providing solutions such as cloud security, cloud DNS, cloud storage, edge computing and video streaming services.

Organization Website:

arvancloud.ir

Reason for PSL Inclusion

ArvanCloud recently announced arvanedge.ir as a way to easily deploy serverless applications running on ArvanCloud Edge Compute Service.

ArvanCloud customers will given a subdomain of arvanedge.ir to which they can deploy their serverless applications. Because subdomains are each controlled by different customers, they should be treated as separate domains for cookie purposes.

I am an engineer on the EdgeCompute team at ArvanCloud.

Number of users this request is being made to serve:

Around 20000 users.

DNS Verification

dig +short TXT _psl.arvanedge.ir
"https://github.com/publicsuffix/list/pull/2205"

Results of Syntax Checker (make test)

make test output

Adding ArvanCloud Edge Compute Domain to public suffix list
@wdhdev
Copy link
Contributor

wdhdev commented Oct 8, 2024

  1. You forgot to update the list of services who's limits you are trying to get around.
  2. You have not checked some of the checkboxes.
  3. Your sorting is wrong, as confusing as it is, Amazon has their own "section" on the PSL, so you should be listed after them.

Are you able to also share the expiry date of your domain?

@3aaber
Copy link
Contributor Author

3aaber commented Oct 8, 2024

Are you able to also share the expiry date of your domain?

The registrar don't show the expiry date of domain, a screenshot from registrar panel is sufficient?

@wdhdev
Copy link
Contributor

wdhdev commented Oct 8, 2024

Yes, it is.

@3aaber
Copy link
Contributor Author

3aaber commented Oct 8, 2024

Yes, it is.

image_2024-10-08_13-51-43

@wdhdev
Copy link
Contributor

wdhdev commented Oct 8, 2024

This all looks good. You just need to fix the sorting of your entry, then this PR should be good to go.

@3aaber
Copy link
Contributor Author

3aaber commented Oct 9, 2024

fix the sorting of your entry

Thank you. Which part need to be fixed?

@wdhdev
Copy link
Contributor

wdhdev commented Oct 9, 2024

You need to move your entry out of the Amazon section.

@3aaber
Copy link
Contributor Author

3aaber commented Oct 9, 2024

I fixed it

@wdhdev
Copy link
Contributor

wdhdev commented Oct 9, 2024

This PR looks good to me 👍

@groundcat
Copy link
Contributor

groundcat commented Oct 9, 2024

  • Expiration (Note: Must STAY >2y at all times)
  • DNS _psl entries (Note: Must STAY in place)
    • "https://github.com/publicsuffix/list/pull/2205"
  • Tests pass
  • Sorting
  • Reasoning/Organization description
    • The use of the domain arvanedge.ir is detailed on the ArvanCloud website in their documentation site, which appears to be consistent with the description in this PR.
    • CT shows 59 certificates for subdomains. Additionally, 43 subdomains were identified by the subdomain finder.
    • The market share seems substantial enough for PSL inclusion, assuming sufficient adoption of this service by ArvanCloud users.
  • Non-personal email address

Number of users this request is being made to serve:
Around 20000 users.

@3aaber Is this user count an estimate of the number of ArvanCloud users who would specifically benefit from the PSL inclusion of the arvanedge.ir domain?

@3aaber
Copy link
Contributor Author

3aaber commented Oct 9, 2024

@3aaber Is this user count an estimate of the number of ArvanCloud users who would specifically benefit from the PSL inclusion of the arvanedge.ir domain?

Yes It is, this new product will be available to current ArvanCloud CDN users that are about more than 20k.

@simon-friedberger simon-friedberger merged commit f66f18d into publicsuffix:master Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants