Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cprapid.com suffix to private section #1892

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

dustin-s
Copy link
Contributor

@dustin-s dustin-s commented Nov 13, 2023

Public Suffix List (PSL) Pull Request (PR) Template

Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowledgements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.

Checklist of required steps

  • Description of Organization

  • Robust Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section

Submitter affirms the following:

  • We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
  • This request was not submitted with the objective of working around other third-party limits
  • The Guidelines were carefully read and understood, and this request conforms
  • The submission follows the guidelines on formatting and sorting

For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

  • Yes, I understand. I could break my organization's website cookies etc. and the rollback timing, etc is acceptable. Proceed.

Description of Organization

cPanel is web hosting control panel software developed by cPanel, LLC. It provides a graphical interface (GUI) and automation tools designed to simplify the process of hosting a web site to the website owner or the "end user". It enables administration through a standard web browser using a three-tier structure.

The submitter, Dustin Scherer, is a Product Manager for several areas of the cPanel & WHM product, including DNS.

Organization Website:
https://www.cpanel.net

Reason for PSL Inclusion

  • We issue LetsEncrypt certificates for server's hostnames for our customers
  • We want our customers' sites to be isolated for other customers (cookies, suffix highlighting, etc)

Number of users this request is being made to serve:
17,677,741 Users (As Of 2023-11-13)

DNS Verification via dig

dig +short TXT _psl.cprapid.com
"https://github.com/publicsuffix/list/pull/1892"

Results of Syntax Checker (make test)

PASS: libpsl_icu_fuzzer
PASS: libpsl_icu_load_dafsa_fuzzer
PASS: libpsl_icu_load_fuzzer
============================================================================
Testsuite summary for libpsl 0.21.2
============================================================================
# TOTAL: 3
# PASS:  3
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in tests
  CC       test-is-public.o
  CC       test-is-public-all.o
  CC       test-is-cookie-domain-acceptable.o
  CC       test-is-public-builtin.o
  CC       test-registrable-domain.o
  CCLD     test-is-cookie-domain-acceptable
  CCLD     test-is-public-builtin
  CCLD     test-is-public
  CCLD     test-is-public-all
  CCLD     test-registrable-domain
PASS: test-is-public-builtin
PASS: test-is-public
PASS: test-is-cookie-domain-acceptable
PASS: test-registrable-domain
PASS: test-is-public-all
============================================================================
Testsuite summary for libpsl 0.21.2
============================================================================
# TOTAL: 5
# PASS:  5
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================

@dustin-s dustin-s marked this pull request as ready for review November 16, 2023 16:50
@dnsguru dnsguru added the NOT IOS FB Submitter attests PR is not #1245 related label Nov 29, 2023
@dustin-s
Copy link
Contributor Author

Is there anything we need to do for this? We're getting close to a release that depends on this work and i want to make sure there isn't anything we need to do to help get this over the line.

Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • tests pass
  • dns proof = pr url
  • sorted to guideline
  • no conflict with base

APPROVED

@dnsguru dnsguru merged commit b7a0606 into publicsuffix:master Feb 12, 2024
sclaeys added a commit to sclaeys/list that referenced this pull request Feb 13, 2024
Add cprapid.com suffix to private section (publicsuffix#1892)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NOT IOS FB Submitter attests PR is not #1245 related
Projects
Status: Done or Won't
Development

Successfully merging this pull request may close these issues.

2 participants