Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update public_suffix_list.dat to include mil.uk / mod.uk #1868

Closed
wants to merge 0 commits into from

Conversation

mrtin42
Copy link

@mrtin42 mrtin42 commented Oct 7, 2023

Added mod.uk and mil.uk second level domains in use by the Ministry of Defense

https://www.nominet.uk/uk-domains/additional-domains/

@dnsguru
Copy link
Member

dnsguru commented Oct 7, 2023

Thank you for taking the time to raise this PR. It is an outstanding example of why this project is reviewed by humans.

As mentioned in issue #1439, where third parties signal changes to entries, especially those delegated TLDs direct from IANA / ICANN namespace, and even more particularly gov/mil, there is validation required.

We would certainly want to see DNS proof to ensure the additions are intentional and deliberate and would involve the appropriate administrative parties, and/or proof of nexus with the affected namespace.

These two submitted are not new namespace. Also, because they have existed for a long period of time, it may be that these are deliberately and intentionally absent in the PSL.

Due to the manner in which presense or absence in the PSL might affect behaviours or how a namespace might be treated by apps or systems that might voluntarily opt to do so, things like the PR are important to confirm are intentional, known changes.

I will be face to face with Nominet Technical staff in two weeks and will review this with them.

@dnsguru dnsguru changed the title Update public_suffix_list.dat Update public_suffix_list.dat to include mil.uk / mod.uk Nov 3, 2023
@dnsguru
Copy link
Member

dnsguru commented Nov 3, 2023

Nominet was spoken to and they pointed to the whois/rdap records for each of these namespaces as indicating that these are each a public suffix, but did not get confirmation that the cookie affectation or other results of PSL listing were desired by the respective namespace operators.

@dnsguru
Copy link
Member

dnsguru commented Nov 3, 2023

https://www.nominet.uk/lookup/ ->

looking up mod.uk or mil.uk

if you scroll to 'Remarks' section, it states that each is a Public Suffix, and there is an RDAP server listed for them.

@dnsguru dnsguru added waiting-followup Blocked for need of follow-up Need to validate requestor/org nexus Will need requestor email domain and company domain(s) to have _psl txt of PR URL in DNS 🚩ICANN (IANA/ICP-3) Section PR changes in the ICANN/IANA section typically reserved for TLDs. labels Nov 3, 2023
@mrtin42 mrtin42 closed this Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚩ICANN (IANA/ICP-3) Section PR changes in the ICANN/IANA section typically reserved for TLDs. Need to validate requestor/org nexus Will need requestor email domain and company domain(s) to have _psl txt of PR URL in DNS waiting-followup Blocked for need of follow-up
Projects
Status: Done or Won't
Development

Successfully merging this pull request may close these issues.

2 participants