Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing tbits.me from public suffix list (rollback #1240) #1642

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

dkhrisanov
Copy link
Contributor

@dkhrisanov dkhrisanov commented Nov 3, 2022

Public Suffix List (PSL) Pull Request (PR) Template

Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowledgements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.

Checklist of required steps

  • Description of Organization

  • Robust Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section
    Request is for removal.

Submitter affirms the following:

  • We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)

  • This request was not submitted with the objective of working around other third-party limits

  • The Guidelines were carefully read and understood, and this request conforms

  • The submission follows the guidelines on formatting and sorting


For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

  • Yes, I understand. I could break my organization's website cookies etc. and the rollback timing, etc is acceptable. Proceed.

Description of Organization

TradableBits is digital media marketing platform with services to Sports and Entertainment clients.
Organization Website: https://tradablebits.com

Reason for PSL Inclusion

Originally tbits.me was included as part of product development to rollout independent domains for clients. It's no longer relevant and we would like to remove tbits.me from the list.

Number of users this request is being made to serve: 1000

DNS Verification via dig

~/projects/TBITS/list>dig TXT _psl.tbits.me

; <<>> DiG 9.18.1-1ubuntu1.2-Ubuntu <<>> TXT _psl.tbits.me
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 15384
;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 512
;; QUESTION SECTION:
;_psl.tbits.me. IN TXT

;; ANSWER SECTION:
_psl.tbits.me. 300 IN TXT "#1642"

;; Query time: 47 msec
;; SERVER: 8.8.8.8#53(8.8.8.8) (UDP)
;; WHEN: Thu Nov 03 14:33:39 PDT 2022
;; MSG SIZE rcvd: 101

Results of Syntax Checker (make test)

============================================================================
Testsuite summary for libpsl 0.21.1

TOTAL: 3

PASS: 3

SKIP: 0

XFAIL: 0

FAIL: 0

XPASS: 0

ERROR: 0

============================================================================
Making check in tests
CC test-is-public.o
CC test-is-public-all.o
CC test-is-cookie-domain-acceptable.o
CC test-is-public-builtin.o
CC test-registrable-domain.o
CCLD test-is-cookie-domain-acceptable
CCLD test-is-public-builtin
CCLD test-is-public
CCLD test-is-public-all
CCLD test-registrable-domain
PASS: test-is-public-builtin
PASS: test-is-cookie-domain-acceptable
PASS: test-registrable-domain
PASS: test-is-public
PASS: test-is-public-all

Testsuite summary for libpsl 0.21.1

TOTAL: 5

PASS: 5

SKIP: 0

XFAIL: 0

FAIL: 0

XPASS: 0

ERROR: 0

============================================================================
Making check in msvc

@dkhrisanov
Copy link
Contributor Author

Effectively this PR is reversal of #1240

@dnsguru dnsguru added the 😭rollback Requestor seeking to remove or revise an entry label Nov 7, 2022
@dnsguru dnsguru changed the title removing tbits.me from public suffix list removing tbits.me from public suffix list (rollback #1240) Nov 7, 2022
Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Rollback-only
  • Same Submitter
  • Tests Pass
  • No Conflict With Base
  • DNS Validates
    APPROVED

@dnsguru dnsguru merged commit e248cbc into publicsuffix:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😭rollback Requestor seeking to remove or revise an entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants