Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button's are collapse in upload section #55

Open
avsingh999 opened this issue Oct 17, 2018 · 15 comments
Open

button's are collapse in upload section #55

avsingh999 opened this issue Oct 17, 2018 · 15 comments

Comments

@avsingh999
Copy link
Member

https://spectralworkbench.org/upload# short and full resoltuion button looks like this
issu2

What happened before you saw the error

What you expected to happen

Browser, version, and operating system

(to help reproduce the issue)

For bug reports, fill out the above template; for feature requests, you can delete the template.

@avsingh999
Copy link
Member Author

@jywarren @SidharthBansal @ebarry please look this issue and add label
thank you

@jywarren
Copy link
Member

jywarren commented Oct 18, 2018 via email

@avsingh999
Copy link
Member Author

@jywarren thank you :)

@SidharthBansal
Copy link
Member

Can you please make this gci issue? May be gci fto using fto template?

@CodeSarthak
Copy link

CodeSarthak commented Oct 25, 2018

Can someone share a link to the source file for this error?
To resolve this issue, we need the source html file and not the js file.
This one : view-source:https://spectralworkbench.org/upload#
We need the source file of ^
@avsingh999 @SidharthBansal @jywarren

@jywarren
Copy link
Member

jywarren commented Oct 25, 2018 via email

@ghost
Copy link

ghost commented Oct 28, 2018

I dont know what to do in this task exactly.

@ghost
Copy link

ghost commented Oct 28, 2018

please help @avsingh999 @jywarren @SidharthBansal

@ghost
Copy link

ghost commented Oct 28, 2018

help

@avsingh999
Copy link
Member Author

@codesterlife I my view you need to add space between that button's.

@avsingh999
Copy link
Member Author

@jywarren @SidharthBansal what do you think about this button's.
thanks :)

@jywarren
Copy link
Member

I'm sorry, i was wrong about the code link! Here it is:

https://github.com/publiclab/spectral-workbench/blob/aa0975fa8c805bc0fde200bd8df11c5325cc8aad/app/views/spectrums/new.html.erb#L128-L129

You need to add some space (using inline CSS is fine!) between those two buttons, as shown in the code. I hope that helps!

@prajwalkpatil
Copy link

Hi, I am GCI - candidate
and i've done all the required changes here is my pull request-
publiclab/spectral-workbench#417

@prajwalkpatil
Copy link

please review..

@ebarry
Copy link
Member

ebarry commented Mar 18, 2019

This issue appears to have been solved, can someone confirm and potentially close? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants