Send emails to subscribers in batches of 50 to avoid SMTP limit #9570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| bcc: recipients, | ||
| subject: subject | ||
| ) | ||
| while recipients.length > 0 |
There was a problem hiding this comment.
Use recipients.length.positive? instead of recipients.length > 0.
| bcc: recipients, | ||
| subject: subject | ||
| ) | ||
| while recipients.length > 0 |
There was a problem hiding this comment.
Use recipients.length.positive? instead of recipients.length > 0.
| bcc: recipients, | ||
| subject: subject | ||
| ) | ||
| while recipients.length > 0 |
There was a problem hiding this comment.
Use !empty? instead of length > 0.
| bcc: recipients, | ||
| subject: subject | ||
| ) | ||
| while recipients.length > 0 |
There was a problem hiding this comment.
Use !empty? instead of length > 0.
|
Code Climate has analyzed commit 7443d47 and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #9570 +/- ##
=======================================
Coverage ? 81.38%
=======================================
Files ? 98
Lines ? 5926
Branches ? 0
=======================================
Hits ? 4823
Misses ? 1103
Partials ? 0 |
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/steviepubliclab/web/issues/326