Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide emoji list after leaving comment reaction #9564

Merged
merged 1 commit into from
May 4, 2021

Conversation

TildaDares
Copy link
Member

@TildaDares TildaDares commented Apr 26, 2021

Fixes #9563

Screen.Recording.2021-04-30.at.01.10.25.mov

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@TildaDares TildaDares requested a review from a team as a code owner April 26, 2021 22:51
@gitpod-io
Copy link

gitpod-io bot commented Apr 26, 2021

@codeclimate
Copy link

codeclimate bot commented Apr 26, 2021

Code Climate has analyzed commit 87c38e1 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@dbe0db5). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 9178aac differs from pull request most recent head f450a34. Consider uploading reports for the commit f450a34 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9564   +/-   ##
=======================================
  Coverage        ?   43.32%           
=======================================
  Files           ?       98           
  Lines           ?     6223           
  Branches        ?        0           
=======================================
  Hits            ?     2696           
  Misses          ?     3527           
  Partials        ?        0           

Copy link
Contributor

@RuthNjeri RuthNjeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @TildaDares. It looks good to me.

@jywarren jywarren merged commit 39b51e8 into publiclab:main May 4, 2021
@jywarren
Copy link
Member

jywarren commented May 4, 2021

Thank you both!!!!!!

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Emoji list after leaving comment reaction
3 participants