-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http updated to https #8934
http updated to https #8934
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit b0d48bb and detected 0 issues on this pull request. View more on Code Climate. |
how I'll know my changes are merged or my pull request is successful. |
Codecov Report
@@ Coverage Diff @@
## main #8934 +/- ##
=======================================
Coverage ? 81.87%
=======================================
Files ? 100
Lines ? 5941
Branches ? 0
=======================================
Hits ? 4864
Misses ? 1077
Partials ? 0 |
@farhanalws4u Please mention the issue number for which you have opened this PR. I guess you are referring to #8910 , am I right ? If so, mention this at the start of your PR message , the line that say |
uhh yes I have a problem. in the report of my pull request it is said "that Unable to compare commits because the base of the pull request did not upload a coverage report." I am unable to understand this. |
@farhanalws4u your PR fixes #8914 and not #8910. Could you please update that? |
ok thanks , I have updated that. |
Hey @farhanalws4u another PR has already been made for this issue 😞 |
Fixes #8914 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!