Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http updated to https #8934

Closed
wants to merge 1 commit into from
Closed

Conversation

farhanalws4u
Copy link

@farhanalws4u farhanalws4u commented Jan 4, 2021

Fixes #8914 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Jan 4, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@gitpod-io
Copy link

gitpod-io bot commented Jan 4, 2021

@codeclimate
Copy link

codeclimate bot commented Jan 4, 2021

Code Climate has analyzed commit b0d48bb and detected 0 issues on this pull request.

View more on Code Climate.

@farhanalws4u
Copy link
Author

how I'll know my changes are merged or my pull request is successful.

@codecov
Copy link

codecov bot commented Jan 4, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@9c409ec). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8934   +/-   ##
=======================================
  Coverage        ?   81.87%           
=======================================
  Files           ?      100           
  Lines           ?     5941           
  Branches        ?        0           
=======================================
  Hits            ?     4864           
  Misses          ?     1077           
  Partials        ?        0           

@gauravahlawat81
Copy link
Member

@farhanalws4u Please mention the issue number for which you have opened this PR. I guess you are referring to #8910 , am I right ? If so, mention this at the start of your PR message , the line that say Fixes #0000 , change it to, Fixes #8910. Let me know if you need any help!

@farhanalws4u
Copy link
Author

@farhanalws4u Please mention the issue number for which you have opened this PR. I guess you are referring to #8910 , am I right ? If so, mention this at the start of your PR message , the line that say Fixes #0000 , change it to, Fixes #8910. Let me know if you need any help!

uhh yes I have a problem. in the report of my pull request it is said "that Unable to compare commits because the base of the pull request did not upload a coverage report." I am unable to understand this.

@Manasa2850
Copy link
Member

@farhanalws4u your PR fixes #8914 and not #8910. Could you please update that?
Everything else looks good! 💯

@farhanalws4u
Copy link
Author

Fixes #8910 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@farhanalws4u your PR fixes #8914 and not #8910. Could you please update that?
Everything else looks good! 💯

ok thanks , I have updated that.

@coder645
Copy link

coder645 commented Jan 4, 2021

Hey @farhanalws4u another PR has already been made for this issue 😞
Please pick up issues that no one else is working on from next time because we usually merge the PR made earlier.
So we won't be able to merge this PR. Sorry 😢

@Uzay-G Uzay-G closed this Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tags rss http to https
5 participants