Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notify_node_creation.html.erb #8701

Closed
wants to merge 1 commit into from

Conversation

SquintyBoi
Copy link

@SquintyBoi SquintyBoi commented Oct 30, 2020

Excluded tags subscriptions if none are present

Fixes #8682 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Excluded tags subscriptions if none are present
@gitpod-io
Copy link

gitpod-io bot commented Oct 30, 2020

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #8701 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8701   +/-   ##
=======================================
  Coverage   81.89%   81.89%           
=======================================
  Files         101      101           
  Lines        5905     5905           
=======================================
  Hits         4836     4836           
  Misses       1069     1069           

@cesswairimu
Copy link
Collaborator

Hello, I am sorry it seems like this was solved in another PR #8686. Please do consider checking the comments on the issue in future to see if someone is already working on it before starting Closing this... Feel free to mention here #7683 if you need help finding another issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update email notifications to exclude tags subscriptions if none are present
2 participants