Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete answer_test.rb #8517

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Delete answer_test.rb #8517

merged 1 commit into from
Oct 9, 2020

Conversation

damiecode
Copy link
Contributor

@damiecode damiecode commented Oct 9, 2020

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in a uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Oct 9, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@gitpod-io
Copy link

gitpod-io bot commented Oct 9, 2020

@codeclimate
Copy link

codeclimate bot commented Oct 9, 2020

Code Climate has analyzed commit fcb335c and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #8517 into main will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8517      +/-   ##
==========================================
+ Coverage   81.89%   81.91%   +0.01%     
==========================================
  Files         101      101              
  Lines        5894     5894              
==========================================
+ Hits         4827     4828       +1     
+ Misses       1067     1066       -1     
Impacted Files Coverage Δ
app/controllers/questions_controller.rb 90.78% <100.00%> (ø)
app/controllers/users_controller.rb 81.04% <100.00%> (ø)
app/models/answer.rb 73.68% <0.00%> (-26.32%) ⬇️
app/models/answer_selection.rb 31.25% <0.00%> (-6.25%) ⬇️
app/api/srch/search.rb 70.70% <0.00%> (+3.82%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️

@jywarren
Copy link
Member

jywarren commented Oct 9, 2020

I think i see this would fix #8511 ! Hang on let me check...

@jywarren
Copy link
Member

jywarren commented Oct 9, 2020

Awesome, looks great! If you add the text fixes #8511 it will link to the original issue, and also once it's merged, it will auto-magically close that issue!

OK, final review and then I'll merge this, thanks so much!!!

@jywarren jywarren merged commit ef6657f into publiclab:main Oct 9, 2020
@welcome
Copy link

welcome bot commented Oct 9, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@Tlazypanda Tlazypanda mentioned this pull request Oct 11, 2020
5 tasks
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants