Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 0.92.0 to 0.93.0 #8505

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps rubocop from 0.92.0 to 0.93.0.

Release notes

Sourced from rubocop's releases.

RuboCop 0.93

New features

Bug fixes

  • #8810: Fix multiple offense detection for Style/RaiseArgs. (@pbernays)
  • #8151: Fix a false positive for Lint/BooleanSymbol when used within %i[...]. (@fatkodima)
  • #8809: Fix multiple offense detection for Style/For. (@pbernays)
  • #8801: Fix Layout/SpaceAroundEqualsInParameterDefault only registered once in a line. (@rdunlop)
  • #8514: Correct multiple Style/MethodDefParentheses per file. (@rdunlop)
  • #8825: Fix crash in Style/ExplicitBlockArgument when code is called outside of a method. (@ghiculescu)
  • #8718: Fix undefined methods of pseudo location. (@ybiquitous)
  • #8354: Detect regexp named captures in Style/CaseLikeIf cop. (@dsavochkin)
  • #8821: Fix an incorrect autocorrect for Style/NestedTernaryOperator when using a nested ternary operator expression with no parentheses on the outside. (@koic)
  • #8834: Fix a false positive for Style/ParenthesesAsGroupedExpression when method argument parentheses are omitted and hash argument key is enclosed in parentheses. (@koic)
  • #8830: Fix bad autocorrect of Style/StringConcatenation when string includes double quotes. (@tleish)
  • #8807: Fix a false positive for Style/RedundantCondition when using assignment by hash key access. (@koic)
  • #8848: Fix a false positive for Style/CombinableLoops when using the same method with different arguments. (@dvandersluis)
  • #8843: Fix an incorrect autocorrect for Lint/AmbiguousRegexpLiteral when sending method to regexp literal receiver. (@koic)
  • #8842: Save actual status to cache, except corrected. (@hatkyinc2)
  • #8835: Fix an incorrect autocorrect for Style/RedundantInterpolation when using string interpolation for non-operator methods. (@koic)
  • #7495: Example for Lint/AmbiguousBlockAssociation cop. (@AllanSiqueira)
  • #8855: Fix an error for Layout/EmptyLinesAroundAccessModifier and Style/AccessModifierDeclarations when using only access modifier. (@koic)

Changes

  • #8803: (Breaking) RegexpNode#parsed_tree now processes regexps including interpolation (by blanking the interpolation before parsing, rather than skipping). (@owst)
  • #8625: Improve Style/RedundantRegexpCharacterClass and Style/RedundantRegexpEscape by using regexp_parser gem. (@owst)
  • #8646: Faster find of all files in TargetFinder class which improves initial startup speed. (@tleish)
  • #8102: Consider class length instead of block length for Struct.new. ([@tejasbubane][])
  • #7408: Make Gemspec/RequiredRubyVersion cop aware of Gem::Requirement. ([@tejasbubane][])
Changelog

Sourced from rubocop's changelog.

0.93.0 (2020-10-08)

New features

  • #8796: Add new Lint/HashCompareByIdentity cop. ([@fatkodima][])
  • #8833: Add new Style/ClassEqualityComparison cop. ([@fatkodima][])
  • #8668: Add new Lint/RedundantSafeNavigation cop. ([@fatkodima][])
  • #8842: Add notification about cache being used to debug mode. ([@hatkyinc2][])
  • #8822: Make Style/RedundantBegin aware of begin without rescue or ensure. ([@koic][])

Bug fixes

  • #8810: Fix multiple offense detection for Style/RaiseArgs. ([@pbernays][])
  • #8151: Fix a false positive for Lint/BooleanSymbol when used within %i[...]. ([@fatkodima][])
  • #8809: Fix multiple offense detection for Style/For. ([@pbernays][])
  • #8801: Fix Layout/SpaceAroundEqualsInParameterDefault only registered once in a line. ([@rdunlop][])
  • #8514: Correct multiple Style/MethodDefParentheses per file. ([@rdunlop][])
  • #8825: Fix crash in Style/ExplicitBlockArgument when code is called outside of a method. ([@ghiculescu][])
  • #8718: Fix undefined methods of pseudo location. ([@ybiquitous][])
  • #8354: Detect regexp named captures in Style/CaseLikeIf cop. ([@dsavochkin][])
  • #8821: Fix an incorrect autocorrect for Style/NestedTernaryOperator when using a nested ternary operator expression with no parentheses on the outside. ([@koic][])
  • #8834: Fix a false positive for Style/ParenthesesAsGroupedExpression when method argument parentheses are omitted and hash argument key is enclosed in parentheses. ([@koic][])
  • #8830: Fix bad autocorrect of Style/StringConcatenation when string includes double quotes. ([@tleish][])
  • #8807: Fix a false positive for Style/RedundantCondition when using assignment by hash key access. ([@koic][])
  • #8848: Fix a false positive for Style/CombinableLoops when using the same method with different arguments. ([@dvandersluis][])
  • #8843: Fix an incorrect autocorrect for Lint/AmbiguousRegexpLiteral when sending method to regexp literal receiver. ([@koic][])
  • #8842: Save actual status to cache, except corrected. ([@hatkyinc2][])
  • #8835: Fix an incorrect autocorrect for Style/RedundantInterpolation when using string interpolation for non-operator methods. ([@koic][])
  • #7495: Example for Lint/AmbiguousBlockAssociation cop. ([@AllanSiqueira][])
  • #8855: Fix an error for Layout/EmptyLinesAroundAccessModifier and Style/AccessModifierDeclarations when using only access modifier. ([@koic][])

Changes

  • #8803: (Breaking) RegexpNode#parsed_tree now processes regexps including interpolation (by blanking the interpolation before parsing, rather than skipping). ([@owst][])
  • #8625: Improve Style/RedundantRegexpCharacterClass and Style/RedundantRegexpEscape by using regexp_parser gem. ([@owst][])
  • #8646: Faster find of all files in TargetFinder class which improves initial startup speed. ([@tleish][])
  • #8102: Consider class length instead of block length for Struct.new. ([@tejasbubane][])
  • #7408: Make Gemspec/RequiredRubyVersion cop aware of Gem::Requirement. ([@tejasbubane][])
Commits
  • 801d30d Cut 0.93
  • 8f9b913 [Fix #8821] Fix an incorrect autocorrect for Style/NestedTernaryOperator (#...
  • 1a84099 [Fix #8718] Fix undefined methods of pseudo location (#8823)
  • 2f5a210 Keep all specs in dot_position_spec
  • 0efca36 Fix Cop/LayoutPosition autocorrect
  • f123d7c Add tests for Layout/DotPosition cop
  • 53c27fc [Fix #8834] Fix a false positive for Style/ParenthesesAsGroupedExpression (...
  • 01cd876 Add new Style/ClassEqualityComparison cop
  • ffeb697 Merge pull request #8861 from koic/fix_an_example_for_format_string_token
  • e563130 Merge pull request #8856 from koic/fix_an_error_for_two_cops
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file Ruby labels Oct 9, 2020
@gitpod-io
Copy link

gitpod-io bot commented Oct 9, 2020

@codeclimate
Copy link

codeclimate bot commented Oct 9, 2020

Code Climate has analyzed commit ffbf780 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #8505 into main will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8505      +/-   ##
==========================================
- Coverage   82.01%   81.89%   -0.12%     
==========================================
  Files         101      101              
  Lines        5894     5894              
==========================================
- Hits         4834     4827       -7     
- Misses       1060     1067       +7     
Impacted Files Coverage Δ
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.87% <0.00%> (-3.83%) ⬇️

@dependabot-preview dependabot-preview bot merged commit d2a7a63 into main Oct 9, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/rubocop-0.93.0 branch October 9, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Ruby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant