Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Redundant Time Text #8503

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

RuthNjeri
Copy link
Contributor

Fixes #6685

-Removed the redundant time "Made" in the notes view dropdown.

Before
Screenshot 2020-10-08 at 23 06 49
After
Screenshot 2020-10-09 at 08 42 19

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

 Committer: RuthNjeri <[email protected]>

 Author:    RuthNjeri
@welcome
Copy link

welcome bot commented Oct 9, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@gitpod-io
Copy link

gitpod-io bot commented Oct 9, 2020

@codeclimate
Copy link

codeclimate bot commented Oct 9, 2020

Code Climate has analyzed commit ba71760 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #8503 into main will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8503      +/-   ##
==========================================
- Coverage   82.01%   81.89%   -0.12%     
==========================================
  Files         101      101              
  Lines        5894     5894              
==========================================
- Hits         4834     4827       -7     
- Misses       1060     1067       +7     
Impacted Files Coverage Δ
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.87% <0.00%> (-3.83%) ⬇️

@RuthNjeri
Copy link
Contributor Author

@cesswairimu I'm having a build failure due to a system test failing, I've tried running the tests locally to replicate it and investigate but I'm not able to pinpoint which test is related to these changes.. I would appreciate your help in pointing me to the right direction..

@cesswairimu
Copy link
Collaborator

cesswairimu commented Oct 9, 2020

The failure is
Screenshot from 2020-10-09 11-55-43
Which I don't think relates to your changes 🤔
Lets try to restart travis

@cesswairimu cesswairimu closed this Oct 9, 2020
@cesswairimu cesswairimu reopened this Oct 9, 2020
@gitpod-io
Copy link

gitpod-io bot commented Oct 9, 2020

@RuthNjeri
Copy link
Contributor Author

The failure is

Screenshot from 2020-10-09 11-55-43

Which I don't think relates to your changes 🤔

Lets try to restart travis

Thanks @cesswairimu it's now okay, I can pick another issue while I wait for this review? Is there a limit to the number of Pull requests one can have?

@cesswairimu
Copy link
Collaborator

cesswairimu commented Oct 9, 2020

yeah sure, you can pick another issue. There is no limit

@jywarren
Copy link
Member

jywarren commented Oct 9, 2020

This looks awesome. Great work! I love deleting code -- so nice to have less to think about! 😄

Merging! and congrats!

@jywarren jywarren merged commit cb88ee0 into publiclab:main Oct 9, 2020
@welcome
Copy link

welcome bot commented Oct 9, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@RuthNjeri RuthNjeri deleted the remove_redundant_time_text branch October 9, 2020 17:08
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
Committer: RuthNjeri <[email protected]>

 Author:    RuthNjeri
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
Committer: RuthNjeri <[email protected]>

 Author:    RuthNjeri
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
Committer: RuthNjeri <[email protected]>

 Author:    RuthNjeri
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
Committer: RuthNjeri <[email protected]>

 Author:    RuthNjeri
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
Committer: RuthNjeri <[email protected]>

 Author:    RuthNjeri
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
Committer: RuthNjeri <[email protected]>

 Author:    RuthNjeri
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Committer: RuthNjeri <[email protected]>

 Author:    RuthNjeri
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant text written twice: MADE: time
3 participants