-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Redundant Time Text #8503
Conversation
Committer: RuthNjeri <[email protected]> Author: RuthNjeri
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit ba71760 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #8503 +/- ##
==========================================
- Coverage 82.01% 81.89% -0.12%
==========================================
Files 101 101
Lines 5894 5894
==========================================
- Hits 4834 4827 -7
- Misses 1060 1067 +7
|
@cesswairimu I'm having a build failure due to a system test failing, I've tried running the tests locally to replicate it and investigate but I'm not able to pinpoint which test is related to these changes.. I would appreciate your help in pointing me to the right direction.. |
Thanks @cesswairimu it's now okay, I can pick another issue while I wait for this review? Is there a limit to the number of Pull requests one can have? |
yeah sure, you can pick another issue. There is no limit |
This looks awesome. Great work! I love deleting code -- so nice to have less to think about! 😄 Merging! and congrats! |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Committer: RuthNjeri <[email protected]> Author: RuthNjeri
Committer: RuthNjeri <[email protected]> Author: RuthNjeri
Committer: RuthNjeri <[email protected]> Author: RuthNjeri
Committer: RuthNjeri <[email protected]> Author: RuthNjeri
Committer: RuthNjeri <[email protected]> Author: RuthNjeri
Committer: RuthNjeri <[email protected]> Author: RuthNjeri
Committer: RuthNjeri <[email protected]> Author: RuthNjeri
Fixes #6685
-Removed the redundant time "Made" in the notes view dropdown.
Before
After
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!