Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Spamaway test for new user #8469

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Conversation

cypherean
Copy link
Contributor

The user is not created if spamaway test is not passed.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Oct 6, 2020

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #8469 into main will increase coverage by 1.83%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8469      +/-   ##
==========================================
+ Coverage   80.06%   81.89%   +1.83%     
==========================================
  Files         101      101              
  Lines        5919     5899      -20     
==========================================
+ Hits         4739     4831      +92     
+ Misses       1180     1068     -112     
Impacted Files Coverage Δ
app/controllers/comment_controller.rb 86.95% <100.00%> (ø)
app/controllers/map_controller.rb 50.00% <100.00%> (ø)
app/controllers/search_controller.rb 97.67% <100.00%> (+2.32%) ⬆️
app/models/node.rb 91.51% <0.00%> (+0.35%) ⬆️
app/controllers/spam2_controller.rb 71.84% <0.00%> (+0.97%) ⬆️
app/controllers/users_controller.rb 81.11% <0.00%> (+1.11%) ⬆️
app/helpers/application_helper.rb 84.70% <0.00%> (+1.17%) ⬆️
app/api/srch/search.rb 66.87% <0.00%> (+1.27%) ⬆️
app/controllers/admin_controller.rb 80.24% <0.00%> (+1.64%) ⬆️
... and 11 more

@jywarren jywarren merged commit eab9696 into publiclab:main Oct 6, 2020
@jywarren
Copy link
Member

jywarren commented Oct 6, 2020

Awesome! Well done!

@cypherean cypherean mentioned this pull request Oct 6, 2020
5 tasks
@jywarren
Copy link
Member

jywarren commented Oct 6, 2020

image

shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants