Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pagy for search profile and tag method #8458

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

Tlazypanda
Copy link
Collaborator

@Tlazypanda Tlazypanda commented Oct 6, 2020

Follow up pr #8426
added pagy for search profile and tag method

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Screenshots

Screenshot from 2020-10-06 16-21-38
Screenshot from 2020-10-06 16-21-10

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Oct 6, 2020

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@8c9c39d). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8458   +/-   ##
=======================================
  Coverage        ?   65.29%           
=======================================
  Files           ?      101           
  Lines           ?     5959           
  Branches        ?        0           
=======================================
  Hits            ?     3891           
  Misses          ?     2068           
  Partials        ?        0           
Impacted Files Coverage Δ
app/controllers/search_controller.rb 41.86% <0.00%> (ø)

@jywarren
Copy link
Member

jywarren commented Oct 6, 2020

Try rebasing this and it should pass now!

@cesswairimu cesswairimu closed this Oct 6, 2020
@cesswairimu cesswairimu reopened this Oct 6, 2020
@gitpod-io
Copy link

gitpod-io bot commented Oct 6, 2020

@jywarren jywarren merged commit 72b2f69 into publiclab:main Oct 6, 2020
@jywarren
Copy link
Member

jywarren commented Oct 6, 2020

Nice!!! Thanks a ton!!!! 🎉

shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants