Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow-popover #8439

Merged
merged 1 commit into from
Oct 2, 2020
Merged

follow-popover #8439

merged 1 commit into from
Oct 2, 2020

Conversation

urvashigupta7
Copy link
Contributor

Fixes #8171
ezgif com-video-to-gif (4)

@gitpod-io
Copy link

gitpod-io bot commented Sep 29, 2020

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #8439 into main will not change coverage.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8439   +/-   ##
=======================================
  Coverage   81.87%   81.87%           
=======================================
  Files         101      101           
  Lines        5899     5899           
=======================================
  Hits         4830     4830           
  Misses       1069     1069           
Impacted Files Coverage Δ
app/controllers/users_controller.rb 81.11% <0.00%> (ø)
app/models/drupal_content_type_map.rb 92.59% <ø> (-0.27%) ⬇️
app/controllers/application_controller.rb 92.24% <100.00%> (+0.06%) ⬆️
app/controllers/wiki_controller.rb 85.40% <100.00%> (ø)

@urvashigupta7
Copy link
Contributor Author

@cesswairimu Please review 😄

@cesswairimu
Copy link
Collaborator

Travis is taking a really long time here 🤔 I will take a look once its done

Copy link
Member

@avats-dev avats-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@urvashigupta7 looks good to me as I checked on gitpod. 🎉
Also, travis checks have passed but idk why it's not showing here, but you can see on clicking details about the test.

@cesswairimu fyi!

@urvashigupta7
Copy link
Contributor Author

Yes @avats-dev is right. Please take a look @cesswairimu :)

@cesswairimu
Copy link
Collaborator

closing and reopening to restart travis

@cesswairimu cesswairimu reopened this Sep 30, 2020
@gitpod-io
Copy link

gitpod-io bot commented Sep 30, 2020

@avats-dev
Copy link
Member

closing and reopening to restart travis

@cesswairimu same as before, something else is happening here 😆

@urvashigupta7
Copy link
Contributor Author

Travis in other PRs is running only one time. Why it is running two times here? 🤔🤔

@urvashigupta7
Copy link
Contributor Author

@cesswairimu All checks are passing now 😄

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome 🎉 thanks a lot for working on this and the patience with travis 😄

@cesswairimu cesswairimu merged commit 876d0fc into publiclab:main Oct 2, 2020
@urvashigupta7 urvashigupta7 deleted the follow-popover branch October 6, 2020 07:19
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Follow' pop up menu overlaps with navigation bar
3 participants