Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces .count and .length with .size in tag model #8435

Merged
merged 3 commits into from
Sep 29, 2020

Conversation

sangu09
Copy link
Contributor

@sangu09 sangu09 commented Sep 29, 2020

Fixes #8205

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below
    If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Sep 29, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@gitpod-io
Copy link

gitpod-io bot commented Sep 29, 2020

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #8435 into main will decrease coverage by 4.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8435      +/-   ##
==========================================
- Coverage   81.87%   77.36%   -4.52%     
==========================================
  Files         101      101              
  Lines        5899     6004     +105     
==========================================
- Hits         4830     4645     -185     
- Misses       1069     1359     +290     
Impacted Files Coverage Δ
app/models/tag.rb 97.51% <100.00%> (ø)
app/controllers/openid_controller.rb 0.00% <0.00%> (-53.90%) ⬇️
app/controllers/comment_controller.rb 72.82% <0.00%> (-14.14%) ⬇️
app/controllers/users_controller.rb 69.62% <0.00%> (-11.49%) ⬇️
app/controllers/application_controller.rb 84.34% <0.00%> (-7.83%) ⬇️
app/models/comment.rb 69.79% <0.00%> (-7.72%) ⬇️
app/controllers/home_controller.rb 91.93% <0.00%> (-6.46%) ⬇️
app/controllers/admin_controller.rb 74.48% <0.00%> (-5.77%) ⬇️
app/models/spamaway.rb 92.30% <0.00%> (-2.57%) ⬇️
app/controllers/notes_controller.rb 81.85% <0.00%> (-1.62%) ⬇️
... and 6 more

@sangu09
Copy link
Contributor Author

sangu09 commented Sep 29, 2020

@publiclab/reviewers can someone please review it. Thanks!

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!! Thanks so much!

@jywarren jywarren merged commit fd15468 into publiclab:main Sep 29, 2020
@welcome
Copy link

welcome bot commented Sep 29, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

Awesome!!! 👍 🎉 🎉 🎉 🎉 🎉

shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
* Replaces .count and .length with .size in tag model

* Changes term_data parameters

* Changes .size to .count where it was a parameter rather than a function

Co-authored-by: hritvi <[email protected]>
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
* Replaces .count and .length with .size in tag model

* Changes term_data parameters

* Changes .size to .count where it was a parameter rather than a function

Co-authored-by: hritvi <[email protected]>
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
* Replaces .count and .length with .size in tag model

* Changes term_data parameters

* Changes .size to .count where it was a parameter rather than a function

Co-authored-by: hritvi <[email protected]>
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
* Replaces .count and .length with .size in tag model

* Changes term_data parameters

* Changes .size to .count where it was a parameter rather than a function

Co-authored-by: hritvi <[email protected]>
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
* Replaces .count and .length with .size in tag model

* Changes term_data parameters

* Changes .size to .count where it was a parameter rather than a function

Co-authored-by: hritvi <[email protected]>
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* Replaces .count and .length with .size in tag model

* Changes term_data parameters

* Changes .size to .count where it was a parameter rather than a function

Co-authored-by: hritvi <[email protected]>
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
* Replaces .count and .length with .size in tag model

* Changes term_data parameters

* Changes .size to .count where it was a parameter rather than a function

Co-authored-by: hritvi <[email protected]>
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* Replaces .count and .length with .size in tag model

* Changes term_data parameters

* Changes .size to .count where it was a parameter rather than a function

Co-authored-by: hritvi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace .count and .length in tag model with .size
2 participants