-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaces .count and .length with .size in tag model #8435
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Codecov Report
@@ Coverage Diff @@
## main #8435 +/- ##
==========================================
- Coverage 81.87% 77.36% -4.52%
==========================================
Files 101 101
Lines 5899 6004 +105
==========================================
- Hits 4830 4645 -185
- Misses 1069 1359 +290
|
@publiclab/reviewers can someone please review it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!! Thanks so much!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Awesome!!! 👍 🎉 🎉 🎉 🎉 🎉 |
* Replaces .count and .length with .size in tag model * Changes term_data parameters * Changes .size to .count where it was a parameter rather than a function Co-authored-by: hritvi <[email protected]>
* Replaces .count and .length with .size in tag model * Changes term_data parameters * Changes .size to .count where it was a parameter rather than a function Co-authored-by: hritvi <[email protected]>
* Replaces .count and .length with .size in tag model * Changes term_data parameters * Changes .size to .count where it was a parameter rather than a function Co-authored-by: hritvi <[email protected]>
* Replaces .count and .length with .size in tag model * Changes term_data parameters * Changes .size to .count where it was a parameter rather than a function Co-authored-by: hritvi <[email protected]>
* Replaces .count and .length with .size in tag model * Changes term_data parameters * Changes .size to .count where it was a parameter rather than a function Co-authored-by: hritvi <[email protected]>
* Replaces .count and .length with .size in tag model * Changes term_data parameters * Changes .size to .count where it was a parameter rather than a function Co-authored-by: hritvi <[email protected]>
* Replaces .count and .length with .size in tag model * Changes term_data parameters * Changes .size to .count where it was a parameter rather than a function Co-authored-by: hritvi <[email protected]>
* Replaces .count and .length with .size in tag model * Changes term_data parameters * Changes .size to .count where it was a parameter rather than a function Co-authored-by: hritvi <[email protected]>
Fixes #8205
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!