Bump rubocop from 0.90.0 to 0.91.0 #8405

dependabot-preview · 2020-09-19T01:48:43Z

Bumps rubocop from 0.90.0 to 0.91.0.

Release notes

RuboCop 0.91

New features

New option --cache-root and support for the RUBOCOP_CACHE_ROOT environment variable. Both can be used to override the AllCops: CacheRootDirectory config, especially in a CI setting. (@sascha-wolf)

#8582: Add new Layout/BeginEndAlignment cop. (@koic)

#8699: Add new Lint/IdentityComparison cop. (@koic)

Add new Lint/UselessTimes cop. (@dvandersluis)

#8707: Add new Lint/ConstantDefinitionInBlock cop. ([@eugeneius][])

Bug fixes

#8627: Fix a false positive for Lint/DuplicateRequire when same feature argument but different require method. (@koic)

#8674: Fix an error for Layout/EmptyLineAfterMultilineCondition when conditional is at the top level. ([@fatkodima][])

#8658: Fix a false positive for Style/RedundantSelfAssignment when calling coercion methods. ([@fatkodima][])

#8669: Fix an offense creation for Lint/EmptyFile. ([@fatkodima][])

#8607: Fix a false positive for Lint/UnreachableLoop when conditional branch includes continue statement preceding break statement. ([@fatkodima][])

#8572: Fix a false positive for Style/RedundantParentheses when parentheses are used like method argument parentheses. (@koic)

#8630: Fix some false positives for Style/HashTransformKeys and Style/HashTransformValues when the receiver is an array. ([@eugeneius][])

#8653: Fix a false positive for Layout/DefEndAlignment when using refinements and private def. (@koic)

#8655: Fix a false positive for Style/ClassAndModuleChildren when using cbase class name. (@koic)

#8654: Fix a false positive for Style/SafeNavigation when checking foo&.empty? in a conditional. (@koic)

#8660: Fix a false positive for Style/ClassAndModuleChildren when using cbase module name. (@koic)

#8664: Fix a false positive for Naming/BinaryOperatorParameterName when naming multibyte character method name. (@koic)

#8604: Fix a false positive for Bundler/DuplicatedGem when gem is duplciated in condition. ([@tejasbubane][])

#8671: Fix an error for Style/ExplicitBlockArgument when using safe navigation method call. (@koic)

#8681: Fix an error for Style/HashAsLastArrayItem with no_braces for empty hash. ([@fsateler][])

#8682: Fix a positive for Style/HashTransformKeys and Style/HashTransformValues when the each_with_object hash is used in the transformed key or value. ([@eugeneius][])

#8688: Mark Style/GlobalStdStream as unsafe autocorrection. ([@marcandre][])

#8642: Fix a false negative for Style/SpaceInsideHashLiteralBraces when a correct empty hash precedes the incorrect hash. (@dvandersluis)

#8683: Make naming cops work with non-ascii characters. ([@tejasbubane][])

#8626: Fix false negatives for Lint/UselessMethodDefinition. ([@marcandre][])

#8698: Fix cache to avoid encoding exception. ([@marcandre][])

#8704: Fix an error for Lint/AmbiguousOperator when using safe navigation operator with a unary operator. (@koic)

#8661: Fix an incorrect auto-correct for Style/MultilineTernaryOperator when returning a multiline ternary operator expression. (@koic)

#8526: Fix a false positive for Style/CaseEquality cop when the receiver is not a camel cased constant. (@koic)

#8673: Fix the JSON parse error when specifying --format=json and --stdin options. (@koic)

Changes

#8470: Do not autocorrect Style/StringConcatenation when parts of the expression are too complex. (@dvandersluis)

#8561: Fix Lint/UselessMethodDefinition to not register an offense when method definition includes optional arguments. ([@fatkodima][])

#8617: Fix Style/HashAsLastArrayItem to not register an offense when all items in an array are hashes. (@dvandersluis)

#8500: Add in? to AllowedMethods for Lint/SafeNavigationChain cop. ([@tejasbubane][])

#8629: Fix the cache being reusable in CI by using crc32 to calculate file hashes rather than mtime, which changes each CI build. (@dvandersluis)

#8663: Fix multiple autocorrection bugs with Style/ClassMethodsDefinitions. (@dvandersluis)

#8621: Add helpful Infinite Loop error message. ([@iSarCasm][])

Changelog

Sourced from rubocop's changelog.

0.91.0 (2020-09-15)

New features

New option --cache-root and support for the RUBOCOP_CACHE_ROOT environment variable. Both can be used to override the AllCops: CacheRootDirectory config, especially in a CI setting. ([@sascha-wolf][])

#8582: Add new Layout/BeginEndAlignment cop. ([@koic][])

#8699: Add new Lint/IdentityComparison cop. ([@koic][])

Add new Lint/UselessTimes cop. ([@dvandersluis][])

#8707: Add new Lint/ConstantDefinitionInBlock cop. ([@eugeneius][])

Bug fixes

#8627: Fix a false positive for Lint/DuplicateRequire when same feature argument but different require method. ([@koic][])

#8674: Fix an error for Layout/EmptyLineAfterMultilineCondition when conditional is at the top level. ([@fatkodima][])

#8658: Fix a false positive for Style/RedundantSelfAssignment when calling coercion methods. ([@fatkodima][])

#8669: Fix an offense creation for Lint/EmptyFile. ([@fatkodima][])

#8607: Fix a false positive for Lint/UnreachableLoop when conditional branch includes continue statement preceding break statement. ([@fatkodima][])

#8572: Fix a false positive for Style/RedundantParentheses when parentheses are used like method argument parentheses. ([@koic][])

#8630: Fix some false positives for Style/HashTransformKeys and Style/HashTransformValues when the receiver is an array. ([@eugeneius][])

#8653: Fix a false positive for Layout/DefEndAlignment when using refinements and private def. ([@koic][])

#8655: Fix a false positive for Style/ClassAndModuleChildren when using cbase class name. ([@koic][])

#8654: Fix a false positive for Style/SafeNavigation when checking foo&.empty? in a conditional. ([@koic][])

#8660: Fix a false positive for Style/ClassAndModuleChildren when using cbase module name. ([@koic][])

#8664: Fix a false positive for Naming/BinaryOperatorParameterName when naming multibyte character method name. ([@koic][])

#8604: Fix a false positive for Bundler/DuplicatedGem when gem is duplciated in condition. ([@tejasbubane][])

#8671: Fix an error for Style/ExplicitBlockArgument when using safe navigation method call. ([@koic][])

#8681: Fix an error for Style/HashAsLastArrayItem with no_braces for empty hash. ([@fsateler][])

#8682: Fix a positive for Style/HashTransformKeys and Style/HashTransformValues when the each_with_object hash is used in the transformed key or value. ([@eugeneius][])

#8688: Mark Style/GlobalStdStream as unsafe autocorrection. ([@marcandre][])

#8642: Fix a false negative for Style/SpaceInsideHashLiteralBraces when a correct empty hash precedes the incorrect hash. ([@dvandersluis][])

#8683: Make naming cops work with non-ascii characters. ([@tejasbubane][])

#8626: Fix false negatives for Lint/UselessMethodDefinition. ([@marcandre][])

#8698: Fix cache to avoid encoding exception. ([@marcandre][])

#8704: Fix an error for Lint/AmbiguousOperator when using safe navigation operator with a unary operator. ([@koic][])

#8661: Fix an incorrect auto-correct for Style/MultilineTernaryOperator when returning a multiline ternary operator expression. ([@koic][])

#8526: Fix a false positive for Style/CaseEquality cop when the receiver is not a camel cased constant. ([@koic][])

#8673: Fix the JSON parse error when specifying --format=json and --stdin options. ([@koic][])

Changes

#8470: Do not autocorrect Style/StringConcatenation when parts of the expression are too complex. ([@dvandersluis][])

#8561: Fix Lint/UselessMethodDefinition to not register an offense when method definition includes optional arguments. ([@fatkodima][])

#8617: Fix Style/HashAsLastArrayItem to not register an offense when all items in an array are hashes. ([@dvandersluis][])

#8500: Add in? to AllowedMethods for Lint/SafeNavigationChain cop. ([@tejasbubane][])

#8629: Fix the cache being reusable in CI by using crc32 to calculate file hashes rather than mtime, which changes each CI build. ([@dvandersluis][])

#8663: Fix multiple autocorrection bugs with Style/ClassMethodsDefinitions. ([@dvandersluis][])

#8621: Add helpful Infinite Loop error message. ([@iSarCasm][])

Commits

e0fc1c0 Cut 0.91
36ea315 Fix build error
80e5740 Fix an error for Style/HashAsLastArrayItem with no_braces for empty hash (#8681)
295b9a6 [Fix #8663] Fix issues with Style/ClassMethodsDefinitions (#8687)
0d3f5e2 [Docs] Improve example of Lint/ToJSON (#8605)
3282218 [Fix #8673] Fix the JSON parse error when specifying --format=json and `--s...
4b6b6c8 Fix an offense creation for Lint/EmptyFile
d9e04a7 [Fix #8621] Improve infinite loop message (#8701)
612c176 Merge pull request #8526 from koic/fix_false_positive_for_style_case_equality
252fe51 Fix a false positive for Style/CaseEquality cop
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

Update frequency
Automerge options (never/patch/minor, and dev/runtime dependencies)
Out-of-range updates (receive only lockfile updates, if desired)
Security updates (receive only security updates, if desired)

Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.90.0 to 0.91.0. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v0.90.0...v0.91.0) Signed-off-by: dependabot-preview[bot] <[email protected]>

gitpod-io · 2020-09-19T01:48:47Z

codecov · 2020-09-19T01:51:45Z

Codecov Report

Merging #8405 into main will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8405      +/-   ##
==========================================
+ Coverage   81.89%   82.01%   +0.11%     
==========================================
  Files         101      101              
  Lines        5900     5900              
==========================================
+ Hits         4832     4839       +7     
+ Misses       1068     1061       -7

Impacted Files	Coverage Δ
app/api/srch/search.rb	`70.06% <0.00%> (+3.82%)`	⬆️
app/services/execute_search.rb	`94.44% <0.00%> (+5.55%)`	⬆️

dependabot-preview bot added dependencies Pull requests that update a dependency file Ruby labels Sep 19, 2020

jywarren approved these changes Sep 21, 2020

View reviewed changes

dependabot-preview bot merged commit 3c12dea into main Sep 21, 2020

dependabot-preview bot deleted the dependabot/bundler/rubocop-0.91.0 branch September 21, 2020 21:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump rubocop from 0.90.0 to 0.91.0 #8405

Bump rubocop from 0.90.0 to 0.91.0 #8405

dependabot-preview bot commented Sep 19, 2020

gitpod-io bot commented Sep 19, 2020

codecov bot commented Sep 19, 2020 •

edited

Loading

Bump rubocop from 0.90.0 to 0.91.0 #8405

Bump rubocop from 0.90.0 to 0.91.0 #8405

Conversation

dependabot-preview bot commented Sep 19, 2020

RuboCop 0.91

New features

Bug fixes

Changes

0.91.0 (2020-09-15)

New features

Bug fixes

Changes

gitpod-io bot commented Sep 19, 2020

codecov bot commented Sep 19, 2020 • edited Loading

Codecov Report

codecov bot commented Sep 19, 2020 •

edited

Loading