-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Probot app to close stale branches #8383
Conversation
Can solve #8375 in a way 😄 |
Codecov Report
@@ Coverage Diff @@
## main #8383 +/- ##
=======================================
Coverage ? 75.18%
=======================================
Files ? 101
Lines ? 6024
Branches ? 0
=======================================
Hits ? 4529
Misses ? 1495
Partials ? 0
|
Hey @jywarren , we can merge this and check if the message by bot seems friendly or not 😄 |
^bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to merge here, many apologies for missing this @sagarpreet-chadha cc @cesswairimu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new changes, thank you Jeff 💯 🎉
Yes let's merge this 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @Sagarpreet! Went through #8375. I believe one problem which still remain is of having the branch as probot only close the issue/PR, doesn't delete the branch.
For solving the branch deletion problem, we can use https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/managing-the-automatic-deletion-of-branches
or https://probot.github.io/apps/delete-merged-branch. Github approach is something that looks good as we won't be relying on another app and also provide restore functionality.
For past branches, we can do one time cleaning. What do you think @Sagarpreet @jywarren ?
Yes looks like a great idea 🎉 |
Correct, the settings change options seems more reliable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic 🎉 Maybe we could also exclude PRs with the hold
label. thoughts?
Yes we can add, |
Try rebasing this and it should pass now! |
Trying to run this on the latest |
Hooray!!! |
Already probot has closed so many issues/PR's 💯 🚀 |
* Create stale.yml * Better comment and label added * Update .github/stale.yml * Update .github/stale.yml * added "hold" label exemption re: @cesswairimu Co-authored-by: Jeffrey Warren <[email protected]>
* Create stale.yml * Better comment and label added * Update .github/stale.yml * Update .github/stale.yml * added "hold" label exemption re: @cesswairimu Co-authored-by: Jeffrey Warren <[email protected]>
* Create stale.yml * Better comment and label added * Update .github/stale.yml * Update .github/stale.yml * added "hold" label exemption re: @cesswairimu Co-authored-by: Jeffrey Warren <[email protected]>
* Create stale.yml * Better comment and label added * Update .github/stale.yml * Update .github/stale.yml * added "hold" label exemption re: @cesswairimu Co-authored-by: Jeffrey Warren <[email protected]>
* Create stale.yml * Better comment and label added * Update .github/stale.yml * Update .github/stale.yml * added "hold" label exemption re: @cesswairimu Co-authored-by: Jeffrey Warren <[email protected]>
* Create stale.yml * Better comment and label added * Update .github/stale.yml * Update .github/stale.yml * added "hold" label exemption re: @cesswairimu Co-authored-by: Jeffrey Warren <[email protected]>
* Create stale.yml * Better comment and label added * Update .github/stale.yml * Update .github/stale.yml * added "hold" label exemption re: @cesswairimu Co-authored-by: Jeffrey Warren <[email protected]>
* Create stale.yml * Better comment and label added * Update .github/stale.yml * Update .github/stale.yml * added "hold" label exemption re: @cesswairimu Co-authored-by: Jeffrey Warren <[email protected]>
Installing and configuring https://probot.github.io/apps/stale/