Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probot app to close stale branches #8383

Merged
merged 5 commits into from
Oct 6, 2020
Merged

Probot app to close stale branches #8383

merged 5 commits into from
Oct 6, 2020

Conversation

sagarpreet-chadha
Copy link
Contributor

@sagarpreet-chadha sagarpreet-chadha commented Sep 7, 2020

Installing and configuring https://probot.github.io/apps/stale/

image

@gitpod-io
Copy link

gitpod-io bot commented Sep 7, 2020

@sagarpreet-chadha
Copy link
Contributor Author

Can solve #8375 in a way 😄

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@b5dbe8e). Click here to learn what that means.
The diff coverage is 81.13%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8383   +/-   ##
=======================================
  Coverage        ?   75.18%           
=======================================
  Files           ?      101           
  Lines           ?     6024           
  Branches        ?        0           
=======================================
  Hits            ?     4529           
  Misses          ?     1495           
  Partials        ?        0           
Impacted Files Coverage Δ
app/models/drupal_content_type_map.rb 92.59% <ø> (ø)
app/controllers/users_controller.rb 68.51% <28.57%> (ø)
app/controllers/notes_controller.rb 81.85% <66.66%> (ø)
app/controllers/questions_controller.rb 81.57% <75.00%> (ø)
app/controllers/wiki_controller.rb 78.83% <80.00%> (ø)
app/models/node.rb 90.45% <87.50%> (ø)
app/controllers/application_controller.rb 84.48% <100.00%> (ø)
app/controllers/comment_controller.rb 72.82% <100.00%> (ø)
app/controllers/like_controller.rb 72.22% <100.00%> (ø)
app/controllers/map_controller.rb 50.00% <100.00%> (ø)
... and 3 more

@sagarpreet-chadha
Copy link
Contributor Author

Hey @jywarren , we can merge this and check if the message by bot seems friendly or not 😄

@sagarpreet-chadha
Copy link
Contributor Author

^bump

.github/stale.yml Outdated Show resolved Hide resolved
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to merge here, many apologies for missing this @sagarpreet-chadha cc @cesswairimu

Copy link
Contributor

@Sagarpreet Sagarpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new changes, thank you Jeff 💯 🎉
Yes let's merge this 👍

Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Sagarpreet! Went through #8375. I believe one problem which still remain is of having the branch as probot only close the issue/PR, doesn't delete the branch.

For solving the branch deletion problem, we can use https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/managing-the-automatic-deletion-of-branches

or https://probot.github.io/apps/delete-merged-branch. Github approach is something that looks good as we won't be relying on another app and also provide restore functionality.

For past branches, we can do one time cleaning. What do you think @Sagarpreet @jywarren ?

@sagarpreet-chadha
Copy link
Contributor Author

Yes looks like a great idea 🎉

@sagarpreet-chadha
Copy link
Contributor Author

Correct, the settings change options seems more reliable.

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 🎉 Maybe we could also exclude PRs with the hold label. thoughts?

@sagarpreet-chadha
Copy link
Contributor Author

Yes we can add, hold looks more intuitive to use 👍 💯

@jywarren
Copy link
Member

jywarren commented Oct 6, 2020

Ah, instance of #8460 here which @cess is working on!

@jywarren
Copy link
Member

jywarren commented Oct 6, 2020

Try rebasing this and it should pass now!

@jywarren jywarren closed this Oct 6, 2020
@jywarren jywarren reopened this Oct 6, 2020
@gitpod-io
Copy link

gitpod-io bot commented Oct 6, 2020

@jywarren
Copy link
Member

jywarren commented Oct 6, 2020

Trying to run this on the latest main branch again!

@jywarren jywarren merged commit 83d55b1 into main Oct 6, 2020
@jywarren
Copy link
Member

jywarren commented Oct 6, 2020

Hooray!!!

@Sagarpreet
Copy link
Contributor

Already probot has closed so many issues/PR's 💯 🚀

shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
* Create stale.yml

* Better comment and label added

* Update .github/stale.yml

* Update .github/stale.yml

* added "hold" label exemption re: @cesswairimu

Co-authored-by: Jeffrey Warren <[email protected]>
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
* Create stale.yml

* Better comment and label added

* Update .github/stale.yml

* Update .github/stale.yml

* added "hold" label exemption re: @cesswairimu

Co-authored-by: Jeffrey Warren <[email protected]>
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
* Create stale.yml

* Better comment and label added

* Update .github/stale.yml

* Update .github/stale.yml

* added "hold" label exemption re: @cesswairimu

Co-authored-by: Jeffrey Warren <[email protected]>
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
* Create stale.yml

* Better comment and label added

* Update .github/stale.yml

* Update .github/stale.yml

* added "hold" label exemption re: @cesswairimu

Co-authored-by: Jeffrey Warren <[email protected]>
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
* Create stale.yml

* Better comment and label added

* Update .github/stale.yml

* Update .github/stale.yml

* added "hold" label exemption re: @cesswairimu

Co-authored-by: Jeffrey Warren <[email protected]>
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* Create stale.yml

* Better comment and label added

* Update .github/stale.yml

* Update .github/stale.yml

* added "hold" label exemption re: @cesswairimu

Co-authored-by: Jeffrey Warren <[email protected]>
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
* Create stale.yml

* Better comment and label added

* Update .github/stale.yml

* Update .github/stale.yml

* added "hold" label exemption re: @cesswairimu

Co-authored-by: Jeffrey Warren <[email protected]>
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* Create stale.yml

* Better comment and label added

* Update .github/stale.yml

* Update .github/stale.yml

* added "hold" label exemption re: @cesswairimu

Co-authored-by: Jeffrey Warren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants