Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have updated translation on users/photo based on #7778 #7779

Merged
merged 1 commit into from
Apr 3, 2020
Merged

I have updated translation on users/photo based on #7778 #7779

merged 1 commit into from
Apr 3, 2020

Conversation

Janet33
Copy link
Contributor

@Janet33 Janet33 commented Apr 3, 2020

I have updated all instances of t( to translation(

Fixes #7778

I have updated all instances of t( to translation(
@Janet33 Janet33 requested a review from a team as a code owner April 3, 2020 01:05
@welcome
Copy link

welcome bot commented Apr 3, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@Janet33
Copy link
Contributor Author

Janet33 commented Apr 3, 2020

Hello @cesswairimu...could you review for me please?

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #7779 into master will increase coverage by 9.57%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7779      +/-   ##
==========================================
+ Coverage   72.49%   82.06%   +9.57%     
==========================================
  Files          97       97              
  Lines        5730     5627     -103     
==========================================
+ Hits         4154     4618     +464     
+ Misses       1576     1009     -567     
Impacted Files Coverage Δ
app/controllers/wiki_controller.rb 85.00% <0.00%> (+0.38%) ⬆️
app/controllers/user_sessions_controller.rb 66.45% <0.00%> (+1.24%) ⬆️
app/controllers/notes_controller.rb 83.40% <0.00%> (+1.65%) ⬆️
app/models/spamaway.rb 94.87% <0.00%> (+2.56%) ⬆️
app/models/revision.rb 88.17% <0.00%> (+3.22%) ⬆️
app/models/user_tag.rb 100.00% <0.00%> (+4.34%) ⬆️
app/models/user.rb 91.05% <0.00%> (+5.44%) ⬆️
app/controllers/admin_controller.rb 78.05% <0.00%> (+5.90%) ⬆️
app/helpers/application_helper.rb 84.52% <0.00%> (+5.95%) ⬆️
app/models/answer_selection.rb 37.50% <0.00%> (+6.25%) ⬆️
... and 15 more

@SidharthBansal SidharthBansal merged commit 13338fd into publiclab:master Apr 3, 2020
@welcome
Copy link

welcome bot commented Apr 3, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@Janet33 Janet33 deleted the patch-1 branch April 3, 2020 11:46
@Janet33
Copy link
Contributor Author

Janet33 commented Apr 3, 2020

Thanks @SidharthBansal .
This is an amazing experience. Looking forward to helping someone as well.
One question, after this what next?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update translation on users/_photo partial
2 participants