Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed tools_places.html.erb #7625

Merged
merged 2 commits into from
Sep 29, 2020
Merged

changed tools_places.html.erb #7625

merged 2 commits into from
Sep 29, 2020

Conversation

Kirti2502
Copy link
Contributor

Changed plots2/app/views/notes/tools_places.html.erb

@welcome
Copy link

welcome bot commented Mar 11, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #7625 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7625   +/-   ##
=======================================
  Coverage   81.87%   81.87%           
=======================================
  Files         101      101           
  Lines        5899     5899           
=======================================
  Hits         4830     4830           
  Misses       1069     1069           

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kirti2502 can you link the issue which this pr is solving? Thanks ✌️

@SidharthBansal
Copy link
Member

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it.
Thanks for contributing on Public Lab

@jywarren
Copy link
Member

AH, found this is linked to #7449 by searching @Kirti2502's username!

@jywarren jywarren reopened this Sep 29, 2020
@jywarren jywarren changed the base branch from master to main September 29, 2020 14:48
@gitpod-io
Copy link

gitpod-io bot commented Sep 29, 2020

@jywarren
Copy link
Member

Great!!! Let's merge! Thanks a ton!!!

@jywarren jywarren merged commit 0bab8fc into publiclab:main Sep 29, 2020
@welcome
Copy link

welcome bot commented Sep 29, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

Thanks again!!!!

manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants