empty wiki table header

[keshavsethi]

Fixes #7531
message added when wiki table is empty

@VladimirMikulic @cesswairimu @nstjean @SidharthBansal
Thanks!

[codecov]

Codecov Report

Merging #7542 into main will increase coverage by 0.13%.
The diff coverage is 83.59%.

@@            Coverage Diff             @@
##             main    #7542      +/-   ##
==========================================
+ Coverage   81.87%   82.01%   +0.13%     
==========================================
  Files          97      101       +4     
  Lines        5612     5894     +282     
==========================================
+ Hits         4595     4834     +239     
- Misses       1017     1060      +43     

Impacted Files	Coverage Δ
app/models/concerns/statistics.rb	96.72% <ø> (ø)
app/models/drupal_content_type_map.rb	92.59% <ø> (-0.27%)	⬇️
app/mailers/admin_mailer.rb	90.90% <12.50%> (-9.10%)	⬇️
app/jobs/digest_spam_job.rb	33.33% <33.33%> (ø)
app/models/user.rb	87.68% <45.00%> (-3.37%)	⬇️
app/controllers/spam2_controller.rb	71.84% <71.84%> (ø)
app/models/comment.rb	77.51% <83.33%> (+0.62%)	⬆️
app/controllers/users_controller.rb	81.04% <84.61%> (-1.07%)	⬇️
app/controllers/notes_controller.rb	83.46% <88.88%> (+0.06%)	⬆️
app/controllers/batch_controller.rb	90.19% <90.19%> (ø)
... and 48 more

[VladimirMikulic]

You could hide buttons "by type" & "Sort by", as well as "Related topics."

[plotsbot]

	1 Warning
⚠️	There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml

	2 Messages
📖	@keshavsethi Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	#

Screenshots 📸 (click to expand)

7542-test_questions.png

7542-test_embeddable_grids.png

7542-test_signup.png

7542-test_viewing_the_settings_page.png

7542-test_tag_by_author_page.png

7542-test_wiki_page_with_inline_grids.png

7542-test_stats.png

7542-test_viewing_the_dashboard.png

7542-test_searching_an_item_from_the_homepage.png

7542-test_signup_modal_form_validation.png

7542-test_tag_stats.png

7542-test_login_modal_form_validation.png

7542-test_questions_shadow.png

7542-test_login_modal.png

7542-test_profile_page.png

7542-test_comments.png

7542-test_tags.png

7542-test_signup_modal.png

7542-test_wiki.png

7542-test_methods.png

7542-test_tag_page.png

7542-test_blog_page_with_location_modal.png

7542-test_tag_wildcard.png

7542-test_signup_modal_disabled_submit_button_on_empty_username.png

7542-test_embeddable_thumbnail_grids.png

7542-test_front_page_with_navbar_search_autocomplete.png

7542-test_spam_moderation_page.png

7542-test_login.png

7542-test_viewing_the_dropdown_menu.png

7542-test_viewing_question_post.png

7542-test_mobile_displays.png

7542-test_simple-data-grapher_powertag.png

7542-test_front.png

7542-test_question_page.png

7542-test_tag_contributors_page.png

7542-test_blog.png

7542-test_people.png

7542-test_wiki_revisions.png

Learn about automated screenshots

Generated by 🚫 Danger

[keshavsethi]

You could hide buttons "by type" & "Sort by", as well as "Related topics."

"By type" drop down is required for switching type thatswhy it is important but sort by and related topics can be hidden
Thanks!

[nstjean]

The "by type" button is used for filtering the results... if there are no results then you can't filter anything. So it can be safely hidden as well.

[keshavsethi]

@nstjean you are right, I will do this
Thanks!!

[SidharthBansal]

Great collab going here too

[cesswairimu]

Hi @keshavsethi, maybe I am missing something but I cannot see the message added from the screenshot

[SidharthBansal]

@keshavsethi please reply to @cesswairimu

[keshavsethi]

Hi @keshavsethi, maybe I am missing something but I cannot see the message added from the screenshot

Hey @cesswairimu @SidharthBansal, Sorry for the late reply. I just reviewed it. The message is coming when wiki table is empty. Can you please share your screenshot or give me more details of whatever you are getting.

<p><%= raw translation('tag.show.no_results_found', tag: params[:id]) %>:</p>
        <p><a href="/search/<%= params[:id] %>">Search for "<%= params[:id] %>"</a></p>

Thnaks!!

[stale]

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add "work in progress" label 🎉 . Otherwise, it will be closed if no further activity occurs in 5 days -- but you can always re-open it if you like! 💯 Thank you for your contributions 🙌 🎈.

[jywarren]

Trying to re-trigger tests!!

[jywarren]

Nice, sorry this took so long!!!