-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fr.yml with translations #10162
Conversation
Added the translation as suggested in issue #10161
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 429259d and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #10162 +/- ##
==========================================
- Coverage 82.13% 81.99% -0.15%
==========================================
Files 98 98
Lines 5968 5977 +9
==========================================
- Hits 4902 4901 -1
- Misses 1066 1076 +10
|
Thank you @comic-dev! This looks good so far! @imajit Can you review this one? It will only take a few mins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thoughts, even though I'm not familiar with the translation files, I think this seems simple enough that it's easily mergeable. Merging now!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Congrats @comic-dev! |
Added the translation as suggested in issue publiclab#10161
Hi @noi5e , Sorry for the late reply
|
@imajit Thanks so much for the detailed explanation! That means I'll have to revert the changes in this PR and will close the other issues that are open with similar updates to the translation files. |
Added the translation as suggested in issue publiclab#10161
This reverts commit 021369f.
Added the translation as suggested in issue publiclab#10161
This reverts commit 021369f.
Added the translation as suggested in issue #10161
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below