Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fr.yml with translations #10162

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Update fr.yml with translations #10162

merged 1 commit into from
Sep 17, 2021

Conversation

comic-dev
Copy link
Contributor

Added the translation as suggested in issue #10161

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • [-] screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Added the translation as suggested in issue #10161
@welcome
Copy link

welcome bot commented Sep 16, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Sep 16, 2021

@codeclimate
Copy link

codeclimate bot commented Sep 16, 2021

Code Climate has analyzed commit 429259d and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #10162 (429259d) into main (f41f8e7) will decrease coverage by 0.14%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10162      +/-   ##
==========================================
- Coverage   82.13%   81.99%   -0.15%     
==========================================
  Files          98       98              
  Lines        5968     5977       +9     
==========================================
- Hits         4902     4901       -1     
- Misses       1066     1076      +10     
Impacted Files Coverage Δ
app/models/tag.rb 93.26% <44.44%> (-4.27%) ⬇️
app/controllers/tag_controller.rb 80.42% <50.00%> (ø)
app/controllers/home_controller.rb 96.05% <100.00%> (-2.62%) ⬇️
app/controllers/images_controller.rb 72.50% <100.00%> (+2.22%) ⬆️
app/controllers/notes_controller.rb 85.09% <100.00%> (+0.22%) ⬆️
app/helpers/application_helper.rb 87.62% <100.00%> (+2.21%) ⬆️
app/models/image.rb 82.05% <100.00%> (-0.45%) ⬇️
app/models/user.rb 86.12% <100.00%> (ø)
app/services/search_service.rb 94.89% <100.00%> (-0.21%) ⬇️
... and 3 more

@noi5e noi5e requested a review from imajit September 16, 2021 19:15
@noi5e
Copy link
Contributor

noi5e commented Sep 16, 2021

Thank you @comic-dev! This looks good so far!

@imajit Can you review this one? It will only take a few mins.

Copy link
Contributor

@noi5e noi5e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thoughts, even though I'm not familiar with the translation files, I think this seems simple enough that it's easily mergeable. Merging now!

@noi5e noi5e merged commit 021369f into publiclab:main Sep 17, 2021
@welcome
Copy link

welcome bot commented Sep 17, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@noi5e
Copy link
Contributor

noi5e commented Sep 17, 2021

Congrats @comic-dev!

shloka-gupta pushed a commit to shloka-gupta/plots2 that referenced this pull request Sep 18, 2021
Added the translation as suggested in issue publiclab#10161
@imajit
Copy link
Contributor

imajit commented Sep 18, 2021

Hi @noi5e , Sorry for the late reply
Each translation file is linked with its corresponding Transifex resources. We export new strings from en.yml files to the project and the translation of corresponding strings is imported into language yml files. So only transifex bot must add commits to language.yml(by language i mean to say all other languages except English) and strings to be translated can be added to en.yml file.
Adding translation directly to language files except en.yml can make things a bit tricky.
Transifex project syncs the en.yml file regularly but the other language files are only synced when they are completely reviewed, or we initiate a manual sync. So if we directly add strings to the language files like in this case we add to fr.yml

  • If the key is not present in en.yml file for instance let's say community.community_title is not present in en.yml file and we add a translation to it in fr.yml file, syncing becomes difficult because we would have to add all the keys missing in en.yml, wait for it to sync and then rerun the entire thing, else we might lose these translations.
  • Till we don't sync the files these translations will not be reflected on the Project dashboard so the Translation team cannot review it and in the worst case, we might end up having different translations for the same string - one by the Translation team and one added by direct contributions.
    So, while I'm glad @comic-dev wants to help with the Translation project and appreciate the work, adding translations straight to the language file is not the best way to go about it.
    Here is a link to the Translation wiki https://publiclab.org/wiki/translation , you can add yourself to the Transifex project and add translation to the Transifex project.

@noi5e
Copy link
Contributor

noi5e commented Sep 18, 2021

@imajit Thanks so much for the detailed explanation!

That means I'll have to revert the changes in this PR and will close the other issues that are open with similar updates to the translation files.

@jywarren
Copy link
Member

Screenshot_20210918-134944

Reverting! Pic for ref. No big deal, thanks!!

jywarren added a commit that referenced this pull request Sep 18, 2021
noi5e pushed a commit that referenced this pull request Sep 18, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
Added the translation as suggested in issue publiclab#10161
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Added the translation as suggested in issue publiclab#10161
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants