New travis config and rails4 #635

cesswairimu · 2019-05-26T23:07:46Z

Test if new travis config will finish if added to rails 4 upgrade branch

right_aws is no longer maintained, was throwing an error

render :text will be deprecated and poses a security risk

codeclimate · 2019-05-26T23:08:20Z

app/controllers/tags_controller.rb

    else
      flash[:error] = 'You must be logged in to add tags'
-      redirect_to '/login?back_to=/maps/' + @map.slug
+      redirect_to "/login?back_to=/maps/#{@map.slug}"


Possible unprotected redirect

codeclimate · 2019-05-26T23:08:20Z

app/controllers/tags_controller.rb

    if logged_in?
      save_tags(@map)
-      redirect_to '/maps/' + @map.slug
+      redirect_to "/maps/#{@map.slug}"


Possible unprotected redirect

codeclimate · 2019-05-26T23:08:21Z

app/controllers/comments_controller.rb

@@ -48,6 +45,12 @@ def destroy
    else
      flash[:error] = 'You do not have permission to delete that comment.'
    end
-    redirect_to "/maps/#{params[:map_id]}"
+    redirect_to "/maps/#{@comment.map.slug}"


Possible unprotected redirect

codeclimate · 2019-05-26T23:08:21Z

app/controllers/comments_controller.rb

-      @comment.update_attribute(:body, params[:comment][:body])
-      redirect_to '/maps/' + params[:map_id]
+      @comment.update_attributes(comment_params)
+      redirect_to "/maps/#{@comment.map.slug}"


Possible unprotected redirect

codeclimate · 2019-05-26T23:08:21Z

test/functional/comments_controller_test.rb

-      map_id: @map.slug,
-      comment: {
+    post(:create, comment: {
+         map_id: @map.id,


Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.

codeclimate · 2019-05-26T23:08:23Z

Code Climate has analyzed commit be3adbc and detected 51 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	2
Style	39
Security	10

Note: there are 6 critical issues.

View more on Code Climate.

codecov · 2019-05-26T23:19:45Z

Codecov Report

Merging #635 into main will decrease coverage by 39.91%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             main     #635       +/-   ##
===========================================
- Coverage   71.27%   31.35%   -39.92%     
===========================================
  Files          32       32               
  Lines        1288     1502      +214     
===========================================
- Hits          918      471      -447     
- Misses        370     1031      +661

Impacted Files	Coverage Δ
app/models/user.rb	`74.19% <ø> (-16.44%)`	⬇️
app/models/tag.rb	`87.5% <ø> (-12.5%)`	⬇️
app/models/node.rb	`100% <ø> (ø)`	⬆️
app/models/annotation.rb	`50% <ø> (-30%)`	⬇️
app/models/comment.rb	`83.33% <ø> (-16.67%)`	⬇️
app/models/way.rb	`75% <ø> (-5%)`	⬇️
app/models/export.rb	`25% <0%> (-69.45%)`	⬇️
app/controllers/feeds_controller.rb	`0% <0%> (-100%)`	⬇️
app/controllers/users_controller.rb	`0% <0%> (-100%)`	⬇️
app/models/map.rb	`36.12% <0%> (-48.59%)`	⬇️
... and 29 more

cesswairimu · 2019-05-27T00:01:49Z

Hi @alaxalves pulled your branch onto mine and travis ran to completion 🎉 🎉
This is how the output looks like.

❤️ ❤️
I can not view the main output as a whole though.
Is there something we can add so that we can view the whole build log and also these awesome sub-logs?
Thanks

kaustubh-nair · 2019-05-27T10:55:34Z

I can not view the main output as a whole though.
Is there something we can add so that we can view the whole build log and also these awesome sub-logs?
Thanks

Hey Cess, you can view the logs by clicking on the failing jobs right?
I don't think viewing the whole log together is necessary?
Thanks!

alaxalves · 2019-05-27T12:26:07Z

Hi @alaxalves pulled your branch onto mine and travis ran to completion
This is how the output looks like.

I can not view the main output as a whole though.
Is there something we can add so that we can view the whole build log and also these awesome sub-logs?
Thanks

That's great news @cesswairimu. I think that a good next move would be merging #605 into #578. After this we could start working on the problematic controller test. Meanwhile @kaustubh-nair will keep his good work by increasing our test coverage. I'll keep working in our DevOps infra(it's almost done) and I'll start getting more in touch with you @cesswairimu to get #578 fully merged. What do you think, is that a good workplan for those next days? @jywarren @sashadev-sky @icarito tell us what you think too.

PS @cesswairimu : I have split the build logs on purpose, since it makes easier to debug which test is failing, makes our build faster..... and so on. Basically I took the rake test:all and splitted it, summarizing our entire test suite is still running, but in parallel now.

cesswairimu · 2019-05-27T14:11:54Z

@alaxalves yeah sounds like a plan. I think the new travis config should be merged to main though so that others can take advantage of it in the meantime. As for the failing test did you test it on your main to see if it fails for you too? I ran the tests on code envy and it was failing there too. I have been trying to fix it but I cannot find the reason why the file is not being created during export.

kaustubh-nair · 2019-05-27T14:55:11Z

That's great news @cesswairimu. I think that a good next move would be merging #605 into #578. After this we could start working on the problematic controller test. Meanwhile @kaustubh-nair will keep his good work by increasing our test coverage. I'll keep working in our DevOps infra(it's almost done) and I'll start getting more in touch with you @cesswairimu to get #578 fully merged. What do you think, is that a good workplan for those next days? @jywarren @sashadev-sky @icarito tell us what you think too.

PS @cesswairimu : I have split the build logs on purpose, since it makes easier to debug which test is failing, makes our build faster..... and so on. Basically I took the rake test:all and splitted it, summarizing our entire test suite is still running, but in parallel now.

I will soon be done with the test coverage. After that @cesswairimu I can give your upgrade some help if you'd like. We should push the upgrade to unstable (Mapknitter has an unstable right?) so everyone can test it and create issues.
A good step after that would be changing Bower to Yarn (#351)

alaxalves · 2019-05-27T17:49:53Z

That's great news @cesswairimu. I think that a good next move would be merging #605 into #578. After this we could start working on the problematic controller test. Meanwhile @kaustubh-nair will keep his good work by increasing our test coverage. I'll keep working in our DevOps infra(it's almost done) and I'll start getting more in touch with you @cesswairimu to get #578 fully merged. What do you think, is that a good workplan for those next days? @jywarren @sashadev-sky @icarito tell us what you think too.
PS @cesswairimu : I have split the build logs on purpose, since it makes easier to debug which test is failing, makes our build faster..... and so on. Basically I took the rake test:all and splitted it, summarizing our entire test suite is still running, but in parallel now.

I will soon be done with the test coverage. After that @cesswairimu I can give your upgrade some help if you'd like. We should push the upgrade to unstable (Mapknitter has an unstable right?) so everyone can test it and create issues.
A good step after that would be changing Bower to Yarn (#351)

Totally agree, Bower is something that needs quick replacement

cesswairimu · 2019-05-27T18:00:31Z

Sounds like a plan thanks @alaxalves and @kaustubh-nair

alaxalves · 2019-05-29T17:55:37Z

Hey @cesswairimu, I have just finished #605 maybe you could merge it into this to test it out. 😄

cesswairimu · 2019-06-06T17:38:57Z

Closing this... the travis changes were merged to main.

alaxalves and others added 30 commits May 27, 2019 02:04

Creating test env

81038e2

Improving travis setup

7b0cecd

Implementing parallel jobs for CI and using db in docker yml

632aee0

ActiveSupport::Testing::Performance extracted to a gem

896048b

ruby prof required as a dependency

f018d62

Configurations update for rails 4.0

25b1104

disable rubocop on bin folder

45abc53

http patch

c9f29bc

Comment out to allow testing

d1ae4d3

no longer supports plugin loading

b696fbd

lock to sprockets 2.12

757de31

Active record patches

b1ef496

remove deprecated test syntax

213d6be

fix failing tests

07b5513

change new super class

697b4af

replace right_aws with right_aws_api

cafc6da

right_aws is no longer maintained, was throwing an error

lock to rails 4.2.11.1

cfbde97

change rails version in install script

5cce36d

remove deprecation warnings

59b5738

make app work

0298c6d

Change test lib to minitest, add minitest reporters

f20d031

active record find patches

e51e5a4

root_in_json include defaulted to false

7ccf9b5

confirm option removed in link helper

fd3d67c

cookies serializer changed to hybrid

ee59cdb

Change render :text to :plain

e42f6b5

render :text will be deprecated and poses a security risk

console for dev web

3e839bc

add minitest reporters to travis

8ab110b

Check and fix interface functionality

75db4d1

fix export functionality

be3adbc

codeclimate bot reviewed May 26, 2019

View reviewed changes

remove test reports dirs

8e9c448

cesswairimu closed this Jun 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New travis config and rails4 #635

New travis config and rails4 #635

cesswairimu commented May 26, 2019 •

edited

Loading

codeclimate bot May 26, 2019

codeclimate bot May 26, 2019

codeclimate bot May 26, 2019

codeclimate bot May 26, 2019

codeclimate bot May 26, 2019

codeclimate bot commented May 26, 2019

codecov bot commented May 26, 2019

cesswairimu commented May 27, 2019 •

edited

Loading

kaustubh-nair commented May 27, 2019

alaxalves commented May 27, 2019 •

edited

Loading

cesswairimu commented May 27, 2019

kaustubh-nair commented May 27, 2019 •

edited

Loading

alaxalves commented May 27, 2019

cesswairimu commented May 27, 2019

alaxalves commented May 29, 2019

cesswairimu commented Jun 6, 2019

New travis config and rails4 #635

New travis config and rails4 #635

Conversation

cesswairimu commented May 26, 2019 • edited Loading

codeclimate bot May 26, 2019

Choose a reason for hiding this comment

codeclimate bot May 26, 2019

Choose a reason for hiding this comment

codeclimate bot May 26, 2019

Choose a reason for hiding this comment

codeclimate bot May 26, 2019

Choose a reason for hiding this comment

codeclimate bot May 26, 2019

Choose a reason for hiding this comment

codeclimate bot commented May 26, 2019

codecov bot commented May 26, 2019

Codecov Report

cesswairimu commented May 27, 2019 • edited Loading

kaustubh-nair commented May 27, 2019

alaxalves commented May 27, 2019 • edited Loading

cesswairimu commented May 27, 2019

kaustubh-nair commented May 27, 2019 • edited Loading

alaxalves commented May 27, 2019

cesswairimu commented May 27, 2019

alaxalves commented May 29, 2019

cesswairimu commented Jun 6, 2019

cesswairimu commented May 26, 2019 •

edited

Loading

cesswairimu commented May 27, 2019 •

edited

Loading

alaxalves commented May 27, 2019 •

edited

Loading

kaustubh-nair commented May 27, 2019 •

edited

Loading