-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #1094 - Add window installations #1095
Conversation
Thanks for opening this pull request! |
Code Climate has analyzed commit 6244e73 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #1095 +/- ##
==========================================
- Coverage 74.03% 73.39% -0.65%
==========================================
Files 40 40
Lines 1398 1398
==========================================
- Hits 1035 1026 -9
- Misses 363 372 +9
|
README.md
Outdated
@@ -195,6 +196,14 @@ $ rails server -b 0.0.0.0 | |||
|
|||
<hr> | |||
|
|||
### Windows Installation | |||
We recommend you either work in a virtual environment, or on a dual booted system to avoid dependencies issues and also Unix system works smoother with Ruby and Rails. This will not only benefit you now for mapknitter, but in future working on other Ruby projects | |||
on as they will get into development further, a linux or mac based OS would be better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Diegoafv, thanks for working on this...could you please remove the new line after the Ruby projects
and also tweak it a bit to read ... but also in future when working on other Ruby projects, a Linux or Mac OS would be smoother to use...
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Diegoafv
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
* Update README.md * correct grammar
Fixes #1094 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/mapknitter-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!