Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue of extra margin in bottom #93

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Fix issue of extra margin in bottom #93

merged 1 commit into from
Nov 13, 2018

Conversation

subhahu123
Copy link
Contributor

@subhahu123 subhahu123 commented Nov 11, 2018

Fixed Issues : #90
##Description of Changes
removing extra margin in bottom by changing demo.css file

##Before changes
screenshot from 2018-11-12 00-38-06
##After Changes
screenshot from 2018-11-12 00-38-52

LGTM
@ajzliu @Rishabh570 @pabisovsky @radheyshyamjangid @starkblaze01 @faithngetich @VaaibhaviSingh

@welcome
Copy link

welcome bot commented Nov 11, 2018

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@subhahu123
Copy link
Contributor Author

@publiclab/reviewers please review

@subhahu123
Copy link
Contributor Author

Copy link
Collaborator

@Rishabh570 Rishabh570 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@subhahu123
Copy link
Contributor Author

@Rishabh570
merge this

@Rishabh570
Copy link
Collaborator

Let others have their POVs first...

@subhahu123
Copy link
Contributor Author

@Rishabh570
NO review still

@subhahu123
Copy link
Contributor Author

@Rishabh570
this repository do not response

@Rishabh570
Copy link
Collaborator

Pinging @publiclab/reviewers

@jywarren
Copy link
Member

Hello @subhahu123 - thank you for your contributions. Please be patient as Public Lab coding is almost entirely a volunteer effort, and a day or two may go by before you get a response, depending on how busy people are. Also, while we understand if you're frustrated, please take a look at our Code of Conduct, and keep in mind that it's important to be respectful and friendly in this community. We deeply appreciate your help in this.

I'll take a look now!

@jywarren jywarren merged commit 651493e into publiclab:main Nov 13, 2018
@welcome
Copy link

welcome bot commented Nov 13, 2018

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://code.publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

Great, thanks again!

@subhahu123 subhahu123 deleted the patch-1 branch November 14, 2018 08:56
TildaDares pushed a commit to TildaDares/community-toolbox that referenced this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants