Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Recent month contributors show up against URL queries. #87

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

Rishabh570
Copy link
Collaborator

Fixes #9

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

@publiclab/reviewers Please take a look...

@Rishabh570
Copy link
Collaborator Author

Here is the working GIF for recent contributors last month (while making this GIF, I collected recent contributors from five repos only just to stay under API limits, it is working fine otherwise...)

issues_9

@Rishabh570
Copy link
Collaborator Author

@jywarren Please take a look :)

@jywarren
Copy link
Member

Oh wow - cool! Shall we put a link in next to "last week" that says "view last month"? Or potentially have a button that refreshes that part of the page only?

Very cool work, here! I'm about to use it to mention recent contributors in a new weekly check-in post! 👍

@jywarren
Copy link
Member

See here! publiclab/plots2#3858

@Rishabh570
Copy link
Collaborator Author

@jywarren I've added a toggle button, please take a look

toggle_contribs

@Rishabh570
Copy link
Collaborator Author

Just some little things are remaining, like the placement of the button and styling & stuff, I need your suggestions for that...

@jywarren
Copy link
Member

jywarren commented Oct 31, 2018 via email

@Rishabh570
Copy link
Collaborator Author

@jywarren Here it is

toggle_final

@Rishabh570
Copy link
Collaborator Author

@jywarren What do you think? Looks good?

@jywarren
Copy link
Member

jywarren commented Nov 1, 2018 via email

@Rishabh570
Copy link
Collaborator Author

@jywarren Ah...actually I'm doing some testing, it will take some time...

@Rishabh570
Copy link
Collaborator Author

@jywarren I guess its ready :)
Here is the working GIF,

ezgif com-optimize 1

@Rishabh570
Copy link
Collaborator Author

Rishabh - you've had enough experience on this repository that you may want
to get merge privileges. I'd still appreciate your checking in with me, but
it may help things move a little faster. If you'd like this, I'd be happy
to add you to the publiclab/reviewers group and you could take more of a
leadership role here! Much appreciated!!!

That would be great 😃

@Rishabh570
Copy link
Collaborator Author

@jywarren Please take a look :)

@jywarren jywarren merged commit 1b16edb into publiclab:main Nov 7, 2018
@jywarren
Copy link
Member

jywarren commented Nov 7, 2018

😄 🙌

@jywarren
Copy link
Member

jywarren commented Nov 7, 2018

I made you a contributor, you should be able to approve, merge, etc!

@jywarren
Copy link
Member

jywarren commented Nov 7, 2018

and, published to gh-pages :-)

@jywarren
Copy link
Member

jywarren commented Nov 7, 2018

Hmm, i don't see any recent contributors this week in https://code.publiclab.org, did something go wrong?

@jywarren
Copy link
Member

jywarren commented Nov 7, 2018

aha - it's my quota. sorry!

Actually maybe we should create some kind of message that says "you've exhausted your quota, try again in x minutes"... you know?

@Rishabh570
Copy link
Collaborator Author

Actually maybe we should create some kind of message that says "you've exhausted your quota, try again in x minutes"... you know?

I'll open an issue for it :)

TildaDares pushed a commit to TildaDares/community-toolbox that referenced this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to set time range in queries: "weekly" + "monthly"
2 participants