-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Recent month contributors show up against URL queries. #87
Conversation
@jywarren Please take a look :) |
Oh wow - cool! Shall we put a link in next to "last week" that says "view last month"? Or potentially have a button that refreshes that part of the page only? Very cool work, here! I'm about to use it to mention recent contributors in a new weekly check-in post! 👍 |
See here! publiclab/plots2#3858 |
@jywarren I've added a toggle button, please take a look |
Just some little things are remaining, like the placement of the button and styling & stuff, I need your suggestions for that... |
Cool, i think it could just be a link, instead of a button, to keep the
design simple... Then it could go on the same line, like:
...week. (*see monthly*)
…On Wed, Oct 31, 2018 at 12:42 AM Rishabh Rawat ***@***.***> wrote:
@jywarren <https://github.com/jywarren> I've added a toggle button,
please take a look
[image: toggle_contribs]
<https://user-images.githubusercontent.com/25483260/47766560-3d661a80-dcf5-11e8-9435-2c59b083dced.gif>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJzckfUHuo_v1brGoeUkgJh1t1K-Cks5uqSn4gaJpZM4X_uYE>
.
|
@jywarren Here it is |
@jywarren What do you think? Looks good? |
I think it looks amazing. Ready to merge? Thank you!!!
Rishabh - you've had enough experience on this repository that you may want
to get merge privileges. I'd still appreciate your checking in with me, but
it may help things move a little faster. If you'd like this, I'd be happy
to add you to the publiclab/reviewers group and you could take more of a
leadership role here! Much appreciated!!!
…On Thu, Nov 1, 2018 at 12:36 PM Rishabh Rawat ***@***.***> wrote:
@jywarren <https://github.com/jywarren> What do you think? Looks good?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ3fo4wRd_gb0vx6xh5H73_91EE8zks5uqyKkgaJpZM4X_uYE>
.
|
@jywarren Ah...actually I'm doing some testing, it will take some time... |
@jywarren I guess its ready :) |
That would be great 😃 |
@jywarren Please take a look :) |
😄 🙌 |
I made you a contributor, you should be able to approve, merge, etc! |
and, published to gh-pages :-) |
Hmm, i don't see any recent contributors this week in https://code.publiclab.org, did something go wrong? |
aha - it's my quota. sorry! Actually maybe we should create some kind of message that says "you've exhausted your quota, try again in x minutes"... you know? |
I'll open an issue for it :) |
Fixes #9
rake test
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment below@publiclab/reviewers Please take a look...