Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Facebook and Twitter icon at the footer for GCI #86

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Add Facebook and Twitter icon at the footer for GCI #86

merged 1 commit into from
Nov 7, 2018

Conversation

janpabisiak
Copy link
Member

@janpabisiak janpabisiak commented Oct 27, 2018

Hello! I edited footer in index.html for task :) Look at this!

Fixes #77

@avsingh999
Copy link
Member

@pabisovsky great work,
please add issue number and a screenshot/gif it would be easy to us
thanks 😄

@DakshGondaliya
Copy link
Member

It looks good to me.
@pabisovsky nice work.

@DakshGondaliya
Copy link
Member

@pabisovsky mention Fixes #issueno in your first comment.

@jywarren
Copy link
Member

Would you mind adding a screenshot? Thank you!!!

@jywarren
Copy link
Member

jywarren commented Nov 7, 2018

Hi, i've added fixes #77 to the description and will merge this now - but please be sure to upload a screenshot and include this fixes #____ in future pull requests, thank you!!!

@jywarren jywarren merged commit b40494e into publiclab:main Nov 7, 2018
@welcome
Copy link

welcome bot commented Nov 7, 2018

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://code.publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@janpabisiak
Copy link
Member Author

hello! My twitter profile is: https://twitter.com/oskryptowany

@joyofsoy
Copy link

hello! My twitter profile is: https://twitter.com/oskryptowany

We'd love to thank you on Twitter, but this Twitter handle didn't work. Is there another account?

TildaDares pushed a commit to TildaDares/community-toolbox that referenced this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants