Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue filter feature on embed.html #70

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

Rishabh570
Copy link
Collaborator

Fixes #28
Here is the GIF...

issue_28

@jywarren Please take a look

@Rishabh570
Copy link
Collaborator Author

@jywarren Whenever you find the time, please take a look here :)

Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Rishabh570 !

@grvsachdeva grvsachdeva added the ready Pull Request approved by reviewer and ready to merge. label Oct 15, 2018
@jywarren jywarren merged commit 7023bfc into publiclab:main Oct 16, 2018
@ghost ghost removed the ready Pull Request approved by reviewer and ready to merge. label Oct 16, 2018
@jywarren
Copy link
Member

Great!!! We should add an example of this to the README as well! Would you mind opening an issue for this?

@Rishabh570 you've been doing some fantastic work on this repository. It's very much appreciated. I think your work will make it possible to be doing a lot more. I don't know if you'd be interested in #57 next? This one will be really cool because it can help us to see when people like you are becoming really active in recent weeks.

@Rishabh570
Copy link
Collaborator Author

Sure I'll do it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants