Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootstrap classes #567

Merged
merged 1 commit into from
May 8, 2022
Merged

Add bootstrap classes #567

merged 1 commit into from
May 8, 2022

Conversation

nawed2611
Copy link
Contributor

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@welcome
Copy link

welcome bot commented May 8, 2022

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@on2onyekachi
Copy link
Contributor

Awesome! @nawed2611

@TildaDares TildaDares linked an issue May 8, 2022 that may be closed by this pull request
5 tasks
Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nawed2611. Great work!!

@TildaDares
Copy link
Member

Thanks for the review @on2onyekachi!!

@TildaDares TildaDares merged commit 98cb8b2 into publiclab:main May 8, 2022
@welcome
Copy link

welcome bot commented May 8, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://code.publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@TildaDares
Copy link
Member

Congratulations @nawed2611 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace inline styles with bootstrap classes
3 participants