Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: #564 Grouped similar inline style rule into demo.css #565

Merged
merged 1 commit into from
May 17, 2022

Conversation

on2onyekachi
Copy link
Contributor

@on2onyekachi on2onyekachi commented May 6, 2022

The first commit fixes: #564,

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@on2onyekachi
Copy link
Contributor Author

@jywarren @TildaDares Please help review so it can be merged.

@TildaDares
Copy link
Member

Hi @on2onyekachi, can you add the issue number to the description above? Thanks!!

@on2onyekachi
Copy link
Contributor Author

Okay @TildaDares, That has been fixed. though this PR has 2 commits for different issues.

@TildaDares
Copy link
Member

Hi @on2onyekachi, it's better if PRs solve only one issue/problem. It's a lot easier to review that way. Thank you!!

@on2onyekachi
Copy link
Contributor Author

Okay, @TildaDares I really didn't realize there was a pending PR from the same branch. Not until after the push. sorry for that. Please how can I go about redoing this?

@TildaDares
Copy link
Member

@on2onyekachi I don't have any experience with splitting commits into different branches but you can checkout this SO answer.

@on2onyekachi
Copy link
Contributor Author

Thanks for the resource @TildaDares. It helped and I have split the commits into two different branches. please review

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @on2onyekachi!!

@TildaDares TildaDares merged commit 9188155 into publiclab:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group similar inline style rule into demo.css
2 participants