Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved link tags to the head. this fixes #550 #551

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

on2onyekachi
Copy link
Contributor

@on2onyekachi on2onyekachi commented Apr 1, 2022

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #550 -style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@welcome
Copy link

welcome bot commented Apr 1, 2022

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@TildaDares
Copy link
Member

@on2onyekachi Can you add the link to the issue being resolved?

@on2onyekachi
Copy link
Contributor Author

@on2onyekachi Can you add the link to the issue being resolved?

Oh, Thanks. I think it's linked already. #550

@TildaDares TildaDares linked an issue Apr 4, 2022 that may be closed by this pull request
Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @on2onyekachi!!

@TildaDares TildaDares merged commit 7487e30 into publiclab:main Apr 4, 2022
@welcome
Copy link

welcome bot commented Apr 4, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://code.publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@on2onyekachi on2onyekachi deleted the move-link branch April 4, 2022 09:56
@TildaDares
Copy link
Member

Congratulations 🎉

@on2onyekachi
Copy link
Contributor Author

Congratulations tada

Thank you for the support. @TildaDares

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move link tags from body to the head section in index.html
2 participants